Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken test #5819

Merged
merged 2 commits into from
Nov 15, 2023
Merged

fix broken test #5819

merged 2 commits into from
Nov 15, 2023

Conversation

wxtim
Copy link
Member

@wxtim wxtim commented Nov 13, 2023

Follow-up to #5794

Fix 4 tests (one symlinked so 09 and 13 are the same test) which were dependent on smtpd, deprecated since Python 3.6 and removed at 3.12.

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Fixes broken tests broken on master - does not need tests, docs, changelog entry or raising against 8.2.x.

@wxtim wxtim marked this pull request as draft November 13, 2023 15:07
@wxtim wxtim marked this pull request as ready for review November 15, 2023 10:55
conda-environment.yml Outdated Show resolved Hide resolved
@MetRonnie MetRonnie added this to the cylc-8.3.0 milestone Nov 15, 2023
@wxtim wxtim self-assigned this Nov 15, 2023
@wxtim wxtim requested a review from MetRonnie November 15, 2023 14:03
@MetRonnie MetRonnie merged commit 1f9c03a into cylc:master Nov 15, 2023
38 of 46 checks passed
@wxtim wxtim deleted the fix.lackofpcre branch November 15, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants