Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pytest-asyncio version #6086

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Conversation

wxtim
Copy link
Member

@wxtim wxtim commented Apr 29, 2024

Don't use Python 3.7 on MacOs on CI.

Exclude non-function releases of pytest-asyncio

Check List

  • This is a small dependency change PR

@MetRonnie
Copy link
Member

Might as well include bumping MacOS to Python 3.8 with this

@wxtim wxtim marked this pull request as draft April 29, 2024 13:48
@wxtim wxtim self-assigned this Apr 29, 2024
@wxtim wxtim marked this pull request as ready for review April 29, 2024 13:56
@wxtim wxtim added this to the 8.2.6 milestone Apr 29, 2024
@wxtim wxtim requested review from MetRonnie and removed request for hjoliver April 29, 2024 14:53
@oliver-sanders
Copy link
Member

No longer needed? - pytest-dev/pytest-asyncio#706 (comment)

setup.cfg Outdated Show resolved Hide resolved
@wxtim wxtim changed the title Exclude Pytest 8.2 from setup.cfg Don't use Python 3.7 on MacOs on CI Apr 30, 2024
@wxtim
Copy link
Member Author

wxtim commented Apr 30, 2024

No longer needed? - pytest-dev/pytest-asyncio#706 (comment)

Entirely about bumping the macos version now. :)

We cannot use pytest-async 0.23 because of pytest-dev/pytest-asyncio#706
We need to use pytest-async 0.23 if we use pytest 8.2 because of pytest-dev/pytest#12269
This may be fixed bt this backport of the fix in pytest-async 0.23: pytest-dev/pytest-asyncio#823

Test MacOs using Python 3.8 becuase GHA no longer providing 3.7 on that platform
Copy link
Member

@MetRonnie MetRonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pytest-asyncio pin is incorrect I think

setup.cfg Outdated Show resolved Hide resolved
Co-authored-by: Ronnie Dutta <[email protected]>
Copy link
Member

@MetRonnie MetRonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, it turns out Python 3.7 is still supported by macos-11 runners, but not macos-13 and above (which only the build workflow uses). Anyway, not too important

@MetRonnie MetRonnie changed the title Don't use Python 3.7 on MacOs on CI Bump pytest-asyncio version Apr 30, 2024
@MetRonnie MetRonnie added the infrastructure GH Actions, Codecov etc. label Apr 30, 2024
@MetRonnie MetRonnie merged commit fd51981 into cylc:8.2.x Apr 30, 2024
32 of 33 checks passed
@hjoliver
Copy link
Member

hjoliver commented May 1, 2024

Oh, it turns out Python 3.7 is still supported by macos-11 runners, but not macos-13 and above (which only the build workflow uses). Anyway, not too important

Yeah in my initial quick hot-fix I only had to tweak this for the build workflow. I mentioned that at at the time, but maybe it got lost in the noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies infrastructure GH Actions, Codecov etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants