-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump pytest-asyncio version #6086
Conversation
Might as well include bumping MacOS to Python 3.8 with this |
8dcb0d5
to
3561fe3
Compare
No longer needed? - pytest-dev/pytest-asyncio#706 (comment) |
Entirely about bumping the macos version now. :) |
We cannot use pytest-async 0.23 because of pytest-dev/pytest-asyncio#706 We need to use pytest-async 0.23 if we use pytest 8.2 because of pytest-dev/pytest#12269 This may be fixed bt this backport of the fix in pytest-async 0.23: pytest-dev/pytest-asyncio#823 Test MacOs using Python 3.8 becuase GHA no longer providing 3.7 on that platform
1ea9718
to
a1cedaf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pytest-asyncio pin is incorrect I think
Co-authored-by: Ronnie Dutta <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, it turns out Python 3.7 is still supported by macos-11 runners, but not macos-13 and above (which only the build workflow uses). Anyway, not too important
Yeah in my initial quick hot-fix I only had to tweak this for the build workflow. I mentioned that at at the time, but maybe it got lost in the noise. |
Don't use Python 3.7 on MacOs on CI.
Exclude non-function releases of pytest-asyncio
Check List