Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly reset log level when temporarily changing it #6327

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Correctly reset log level when temporarily changing it #6327

merged 2 commits into from
Aug 29, 2024

Commits on Aug 23, 2024

  1. Remove pointless if statement

    @MetRonnie
    MetRonnie committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    7e14752 View commit details
    Browse the repository at this point in the history

  2. Correctly reset log level 

    `Logger.getEffectiveLevel()` will return the root logger level if `Logger.level` is `NOTSET`.
In pytest the root logger level is `WARNING`, so in the tests, there were cases where the Cylc logger was being incorrectly reset to `WARNING` instead of `NOTSET`
    @MetRonnie
    MetRonnie committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    6856cee View commit details
    Browse the repository at this point in the history