Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update yarn to v4 #1525

Merged
merged 6 commits into from
Nov 23, 2023
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 22, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
yarn 3.6.4 -> 4.0.0 age adoption passing confidence

Release Notes

yarnpkg/berry (yarn)

v4.0.0

Compare Source


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Oct 22, 2023
@renovate
Copy link
Contributor Author

renovate bot commented Oct 23, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

- Update Node to LTS
- Cancel ongoing run on new push
@MetRonnie MetRonnie force-pushed the renovate/major-yarn-monorepo branch from 892a974 to 96b4d8d Compare October 23, 2023 10:35
@MetRonnie MetRonnie self-assigned this Oct 23, 2023
@oliver-sanders
Copy link
Member

This is pretty bleeding edge (released yesterday).

I would be tempted to hold off for a while and let others flush out issues whilst we're swamped with other things.

Changes: https://github.com/yarnpkg/berry/blob/%40yarnpkg/types/4.0.0/CHANGELOG.md

Note, Node 16 support has been dropped.

@MetRonnie
Copy link
Member

MetRonnie commented Oct 23, 2023

Note, Node 16 support has been dropped.

Should be fine now because I think it was vue-cli / webpack 4 that was causing a problem before?

Also note: Node 16 already hit EOL in September - https://nodejs.org/en/blog/announcements/nodejs16-eol

@MetRonnie MetRonnie marked this pull request as draft October 23, 2023 15:28
@MetRonnie MetRonnie force-pushed the renovate/major-yarn-monorepo branch from e45e411 to 94053d5 Compare October 23, 2023 16:52
const path = require('path')

// Workaround https://github.com/cypress-io/cypress/issues/25397
dns.setDefaultResultOrder('ipv4first')

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would prefer to leave it like this, not restricting it to an env var because that's fiddly (and setting it in bashrc does not affect VSCode tasks which is how I usually run the tests 😞)

@MetRonnie MetRonnie added this to the 2.2.0 milestone Oct 25, 2023
@MetRonnie MetRonnie requested a review from wxtim October 25, 2023 15:57
@MetRonnie MetRonnie marked this pull request as ready for review October 25, 2023 15:57
Copy link
Member

@wxtim wxtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've had a good play. The only issue I found was with using Node 16, which is EOL as Oliver observed.

@oliver-sanders oliver-sanders modified the milestones: 2.2.0, 2.3.0 Nov 2, 2023
@MetRonnie
Copy link
Member

MetRonnie commented Nov 7, 2023

@oliver-sanders Can we get this merged now? It's very fiddly to get E2E tests running on node 18+ without the vite config changes

@MetRonnie MetRonnie force-pushed the renovate/major-yarn-monorepo branch 2 times, most recently from 8b4b24e to 1f4a326 Compare November 15, 2023 11:19
@MetRonnie MetRonnie modified the milestones: 2.4.0, 2.3.0 Nov 15, 2023
@MetRonnie MetRonnie force-pushed the renovate/major-yarn-monorepo branch 3 times, most recently from cc463d9 to 01d0f58 Compare November 17, 2023 10:14
@MetRonnie MetRonnie force-pushed the renovate/major-yarn-monorepo branch from 01d0f58 to ee65436 Compare November 21, 2023 17:11
@MetRonnie MetRonnie requested a review from wxtim November 22, 2023 11:01
@oliver-sanders oliver-sanders merged commit 24475d1 into master Nov 23, 2023
8 checks passed
@oliver-sanders oliver-sanders deleted the renovate/major-yarn-monorepo branch November 23, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants