Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back macos to test matrix #713

Merged
merged 1 commit into from
Aug 2, 2021
Merged

Conversation

kinow
Copy link
Member

@kinow kinow commented Aug 2, 2021

These changes close #590

We've updated to yarn v3. I think macos build should work fine now? It passed on my fork's GH actions. I'll retrigger it a couple times now to confirm it's working OK.

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Already covered by existing tests.
  • No change log entry required (why? e.g. invisible to users).
  • No documentation update required.

@kinow kinow added this to the 0.6.0 milestone Aug 2, 2021
@kinow kinow self-assigned this Aug 2, 2021
@kinow kinow requested a review from oliver-sanders August 2, 2021 01:46
@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2021

Codecov Report

Merging #713 (f31c442) into master (8547b6f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #713   +/-   ##
=======================================
  Coverage   89.97%   89.97%           
=======================================
  Files          79       79           
  Lines        1536     1536           
  Branches      113      113           
=======================================
  Hits         1382     1382           
  Misses        122      122           
  Partials       32       32           
Flag Coverage Δ
e2e 77.99% <ø> (ø)
unittests 79.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8547b6f...f31c442. Read the comment docs.

@kinow
Copy link
Member Author

kinow commented Aug 2, 2021

Triggered new jobs, no issues found. Should be good to be reviewed & merged 🤞

@oliver-sanders oliver-sanders merged commit 5945743 into cylc:master Aug 2, 2021
@kinow kinow deleted the add-macos-back branch August 2, 2021 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GH actions: macos build failing intermitently
3 participants