Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy #309

Merged
merged 4 commits into from
Mar 29, 2022
Merged

Tidy #309

merged 4 commits into from
Mar 29, 2022

Conversation

MetRonnie
Copy link
Member

@MetRonnie MetRonnie commented Feb 11, 2022

Split off from #290

Sibling to cylc/cylc-flow#4683

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Does not need tests
  • No change log entry required
  • No documentation update required.
  • No dependency changes.

@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2022

Codecov Report

Merging #309 (00953c9) into master (ca26cc6) will increase coverage by 0.18%.
The diff coverage is 78.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #309      +/-   ##
==========================================
+ Coverage   80.13%   80.31%   +0.18%     
==========================================
  Files          10       10              
  Lines        1007     1001       -6     
  Branches      198      194       -4     
==========================================
- Hits          807      804       -3     
+ Misses        166      163       -3     
  Partials       34       34              
Impacted Files Coverage Δ
cylc/uiserver/schema.py 82.45% <65.38%> (+5.40%) ⬆️
cylc/uiserver/data_store_mgr.py 68.20% <100.00%> (+0.51%) ⬆️
cylc/uiserver/handlers.py 89.28% <100.00%> (ø)
cylc/uiserver/resolvers.py 41.75% <100.00%> (-2.81%) ⬇️
cylc/uiserver/workflows_mgr.py 89.28% <100.00%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca26cc6...00953c9. Read the comment docs.

Copy link
Member

@wxtim wxtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Tests locally
  • Read

Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hjoliver hjoliver merged commit f0f5050 into cylc:master Mar 29, 2022
@MetRonnie MetRonnie deleted the tidy branch March 29, 2022 10:16
@MetRonnie MetRonnie modified the milestones: 1.1.0, 1.0.2 Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants