Custom command recipe throws an error #764
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See : cypress-io/cypress#18915 An error 'Argument of type '() => void' is not assignable to parameter of type '() => Chainable<any>' throws when you return directly cypress-io/cypress#18915 (comment) fixes cypress-io#763
|
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+14
to
+16
| Cypress.Commands.add('dataCy', (value) => { | ||
| cy.get(`[data-cy=${value}]`) | ||
| }) |
There was a problem hiding this comment.
This change breaks command chaining. The command needs to return the cy.get() chain. Either keep the original one-liner:
Cypress.Commands.add('dataCy', (value) => cy.get(`[data-cy=${value}]`))Or explicitly return the chain:
Cypress.Commands.add('dataCy', (value) => {
return cy.get(`[data-cy=${value}]`)
})Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See : cypress-io/cypress#18915
An error 'Argument of type '() => void' is not assignable to parameter of type '() => Chainable' throws when you return directly
cypress-io/cypress#18915 (comment)
fixes #763