Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some peer dependency warnings #1417

Merged
merged 5 commits into from
Oct 26, 2023
Merged

chore: fix some peer dependency warnings #1417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9a41d38
chore: fix some peer dependency warnings
astone123 Oct 18, 2023
688fa94
move express-graphql back to dev deps
astone123 Oct 18, 2023
ae90ead
revert more unnecessary changes
astone123 Oct 18, 2023
d2d9e63
update lockfile
astone123 Oct 18, 2023
bb7e4cb
remove Percy healthcheck
astone123 Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions cypress.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import _ from "lodash";
import axios from "axios";
import dotenv from "dotenv";
import Promise from "bluebird";
import { percyHealthCheck } from "@percy/cypress/task";
import codeCoverageTask from "@cypress/code-coverage/task";
import { defineConfig } from "cypress";

Expand Down Expand Up @@ -84,7 +83,6 @@ module.exports = defineConfig({
};

on("task", {
percyHealthCheck,
async "db:seed"() {
// seed database with test data
const { data } = await axios.post(`${testDataApiEndpoint}/seed`);
Expand Down
11 changes: 7 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,20 @@
"dependencies": {
"@auth0/auth0-react": "2.1.1",
"@aws-amplify/ui-react": "^5.0.4",
"@babel/core": "7.0.1",
"@babel/plugin-syntax-flow": "^7.14.5",
"@babel/plugin-transform-react-jsx": "^7.14.9",
"@graphql-tools/graphql-file-loader": "7.3.10",
"@graphql-tools/load": "7.5.9",
"@material-ui/core": "4.12.4",
"@material-ui/icons": "4.11.3",
"@material-ui/lab": "4.0.0-alpha.61",
"@matheusluizn/react-google-login": "^5.1.6",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the issues in react-google-login is seems like most people are transitioning to the @react-oath/google package.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mschile trying to switch to this one now - there are some differences in implementation between the two packages. Any objection with leaving this as-is in this PR since I don't have a ton of time to dedicate to this?

"@okta/jwt-verifier": "^3.0.1",
"@okta/okta-auth-js": "^7.3.0",
"@okta/okta-react": "^6.7.0",
"@types/detect-port": "^1.3.2",
"@xstate/react": "2.0.1",
"@xstate/react": "3.0.0",
"aws-amplify": "^5.3.3",
"axios": "0.26.1",
"clsx": "1.1.1",
Expand All @@ -35,24 +39,23 @@
"postinstall-postinstall": "^2.1.0",
"react": "18.2.0",
"react-dom": "18.2.0",
"react-google-login": "5.2.2",
"react-infinite-calendar": "2.3.1",
"react-number-format": "4.9.4",
"react-router": "5.3.4",
"react-router-dom": "5.3.4",
"react-virtualized": "9.22.5",
"shortid": "2.2.16",
"uuid": "8.3.2",
"webpack": "5",
"xstate": "4.35.4",
"yup": "0.32.11"
},
"devDependencies": {
"@babel/plugin-proposal-private-property-in-object": "7.21.11",
"@cypress/code-coverage": "^3.10.0-dev.1",
"@cypress/instrument-cra": "1.4.0",
"@cypress/webpack-dev-server": "^1.6.0",
"@faker-js/faker": "6.1.2",
"@percy/cypress": "2.3.4",
"@percy/cypress": "3.1.2",
"@testing-library/jest-dom": "^5.16.5",
"@testing-library/react": "^14.0.0",
"@types/bcryptjs": "2.4.2",
Expand Down
2 changes: 1 addition & 1 deletion src/containers/AppGoogle.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { authService } from "../machines/authMachine";
import AlertBar from "../components/AlertBar";
import { bankAccountsMachine } from "../machines/bankAccountsMachine";
import PrivateRoutesContainer from "./PrivateRoutesContainer";
import { GoogleLogin, useGoogleLogin } from "react-google-login";
import { GoogleLogin, useGoogleLogin } from "@matheusluizn/react-google-login";

// @ts-ignore
if (window.Cypress) {
Expand Down
Loading