Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add light logo for Github README view #1421

Merged
merged 2 commits into from
Nov 3, 2023

Conversation

astone123
Copy link
Contributor

Closes #1402

We're using rwa-logo.svg for our logo in the readme, which uses the currentColor attribute for its fill color, which should allow the fill to change with the context of where it is placed. It appears that this isn't working correctly in Github when it displays the README.

To fix this, I created rwa-logo-light.svg which explicitly sets the fill colors to white, and added the suffixes that Github will use to display each SVG depending on whether the user is in light mode or dark mode.

The downside to this approach is that some previewers (like the VSCode preview) do handle this correctly, so now they'll show two images side-by-side. I think it's worth the tradeoff to look better on Github though.

Github light mode
Screenshot 2023-10-23 at 5 22 54 PM

Github dark mode
Screenshot 2023-10-23 at 5 23 18 PM

@astone123 astone123 self-assigned this Oct 23, 2023
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c126cd6) 93.89% compared to head (6f2ab11) 93.89%.
Report is 5 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1421   +/-   ##
========================================
  Coverage    93.89%   93.89%           
========================================
  Files           95       95           
  Lines         1606     1606           
  Branches       256      256           
========================================
  Hits          1508     1508           
  Misses          98       98           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cypress
Copy link

cypress bot commented Oct 23, 2023

Passing run #6173 ↗︎

0 448 2 0 Flakiness 0

Details:

add a comment to explain
Project: cypress-realworld-app Commit: 6f2ab1198a
Status: Passed Duration: 31:58 💡
Started: Oct 23, 2023 11:39 PM Ended: Oct 24, 2023 12:11 AM

Review all test suite changes for PR #1421 ↗︎

@jennifer-shehane jennifer-shehane merged commit 04373d0 into develop Nov 3, 2023
29 checks passed
@jennifer-shehane jennifer-shehane deleted the rwa-readme-logo branch November 3, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Real World App" logo almost invisible in dark mode.
2 participants