chore: add light logo for Github README view #1421
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1402
We're using
rwa-logo.svg
for our logo in the readme, which uses the currentColor attribute for its fill color, which should allow the fill to change with the context of where it is placed. It appears that this isn't working correctly in Github when it displays the README.To fix this, I created
rwa-logo-light.svg
which explicitly sets the fill colors towhite
, and added the suffixes that Github will use to display each SVG depending on whether the user is in light mode or dark mode.The downside to this approach is that some previewers (like the VSCode preview) do handle this correctly, so now they'll show two images side-by-side. I think it's worth the tradeoff to look better on Github though.
Github light mode
Github dark mode