Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): remove redundant AWS SDK for JavaScript v2 #1426

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

trivikr
Copy link
Contributor

@trivikr trivikr commented Nov 6, 2023

Issue

From AWS SDK for JavaScript v2 README:

We are formalizing our plans to make the Maintenance Announcement (Phase 2) for AWS SDK for JavaScript v2 in 2023.

Description

I came across cypress-realworld-app when searching for popular projects on GitHub that use AWS SDK for JavaScript v2.
On quick examination, I noticed that the direct dependency on aws-sdk is not required.

I verified that aws-ampliy indirectly uses AWS SDK for JavaScript v3.

$ yarn why @aws-sdk/client-s3
...
=> Found "@aws-sdk/[email protected]"
info Reasons this module exists
   - "aws-amplify#@aws-amplify#storage" depends on it
   - Hoisted from "aws-amplify#@aws-amplify#storage#@aws-sdk#client-s3"

@CLAassistant
Copy link

CLAassistant commented Nov 6, 2023

CLA assistant check
All committers have signed the CLA.

@cypress-app-bot
Copy link

@MikeMcC399

This comment was marked as outdated.

@jennifer-shehane
Copy link
Member

@trivikr Thanks for the contribution! Could you please sign our CLA?

@trivikr
Copy link
Contributor Author

trivikr commented Nov 7, 2023

Could you please sign our CLA?

Done!

@MikeMcC399
Copy link
Contributor

CircleCI has one failure related to Percy

https://app.circleci.com/pipelines/github/cypress-io/cypress-realworld-app/5600/workflows/bf3fe560-f95a-474b-9c53-4226bb02cf8b/jobs/35656

yarn run v1.22.19
warning From Yarn 1.0 onwards, scripts don't require "--" for options to be forwarded. In a future version, any explicit "--" will be forwarded as-is to the scripts.
error Command "percy" not found.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Exited with code exit status 1

@emilyrohrbough emilyrohrbough merged commit 5cc078d into cypress-io:develop Nov 7, 2023
2 checks passed
@trivikr trivikr deleted the remove-aws-sdk branch November 7, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants