-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: #29605 for display: contents parent visibility with correct width check #29680
base: release/14.0.0
Are you sure you want to change the base?
Conversation
|
now it looks like internal error in build for unit tests. |
This looks like unit-tests fail during build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@senpl There are failures in the visibility test in firefox. Please run these locally to ensure they pass.
… issue-29605v2
We've decided to prioritize looking into these visibility fixes in Quarter 4 of this year, when we intend to spend time on Cypress 14 release. It will ease any concerns we have around releasing breaking changes with these fixes and also help us plan the proper time to review these. Tracking here: #29925 |
Updated the base branch to go against release/14.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CV],
"macosx": [
"--macos=MacOSX",
"--apple_deploy_target=13.3"
"--apple_deploy_target=11.0"
],
"iphoneos": [
"--ios",
"--apple_deploy_target=13.0"
],
"iphonesimulator": [
"--ios",
"--apple_deploy_target=13.0"
]
}
}``
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CV],
"macosx": [
"--macos=MacOSX",
"--apple_deploy_target=13.3"
"--apple_deploy_target=11.0"
],
"iphoneos": [
"--ios",
"--apple_deploy_target=13.0"
],
"iphonesimulator": [
"--ios",
"--apple_deploy_target=13.0"
]
}
}``
display:contents
when determining visibility of child elements #29605As discussed in fix: #29093 for elements with length in rem #29224 in separate part.
Additional details
I implemented solution proposed in #29224 still I have to add width and height check because without them element was still visible as with 0 width.
This time it is clear from most other commits and only core changes to make this work.
Steps to test
html
How has the user experience changed?
Users has to use {force: true} to click such elements, checking thier visibility was not possible. Now it should be possible
PR Tasks
cypress-documentation
?type definitions
?