-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 29687 an issue where parent width 0 signal element hidden when it's visible #29688
base: release/14.0.0
Are you sure you want to change the base?
Conversation
|
It was done similar in the past as could be seen in #5974 |
One test updated because element that was in test in fact was visible, and incorrectly exected to be hidden and not visible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@senpl There a failure regarding visibility in the tests.
Now looks like cert errors, so probably something with pipeline. |
Co-authored-by: Mike McCready <[email protected]>
We've decided to prioritize looking into these visibility fixes in Quarter 4 of this year, when we intend to spend time on Cypress 14 release. It will ease any concerns we have around releasing breaking changes with these fixes and also help us plan the proper time to review these. Tracking here: #29925 |
Updated the base branch to go against release/14.0.0 |
Additional details
This is necessery to be consistent with what users see in browsers.
Steps to test
expect(cy.$$('#id2 >div > p')).to.be.visible
cy.get('#id2 >div > p').click()`
How has the user experience changed?
Some elementst that previously was marked as hidden now are will correctly be makresd as visible
PR Tasks
cypress-documentation
?type definitions
?