Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRAFT: build document.domain removal binary #30768

Draft
wants to merge 60 commits into
base: release/14.0.0
Choose a base branch
from
Draft

DRAFT: build document.domain removal binary #30768

wants to merge 60 commits into from

Conversation

AtofStryker
Copy link
Contributor

DO NOT MERGE

  • Closes N/A

only opened to build a binary to test projects against

Additional details

Steps to test

How has the user experience changed?

PR Tasks

@cacieprins
remove experimentalSkipDomainInjection, add and deprecate injectDocum…
5b42419 
…entDomain
@cacieprins
remove experimentalSkipDomainInjection, add injectDocumentDomain
151952d
@cacieprins
begin rethreading domain injection
dc4fb0b
@cacieprins
complete document domain transition
330adc4
@cacieprins
move some cookie specs to separate test run
2000405
@cacieprins
origin and privileged commands with default docdom inject
0f822b5
@cacieprins
fix privileged channel when injecting document domain
8275e4d
@cacieprins
rm unnecessary .getOrigin abstraction in cors lib
4a52817
@cacieprins
move remote-states in prep for refactor Replace Conditional with Poly…
b3b60a1 
…morphism
@cacieprins
refactor remote states to strategy pattern
a8f6406
@cacieprins
cookie commands work as expected w cross origin bridge on different o…
c54224b 
…rigins
@cacieprins
some origin tests updated
110996b
@cacieprins
run tests with document domain enabled
4895219
@cacieprins
run tests actually
33d33cd
@cacieprins
use correct config, swap conditional
1d348c9
@cacieprins
check-ts
8b943d0
@cacieprins
inject documetn domain for webkit tests
1166858
@cacieprins
do not exec injectDocumetnDomain in parallel
25c3ac7
@cacieprins
fix ServerBase construction in tests to include cfg now
b4c0be3
@cacieprins
pass cfg to ServerBase
3e613f0
@cacieprins
improved integration tests
b6090f7
@cacieprins
remove document domain checks for all server integration specs - will…
4da149d 
… add injectDocumentDomain cases
@cacieprins
tests for injecting document domain when configured to
9bcc1f3
@cacieprins
square away server integration tests
e8ccb4d
@cacieprins
ensure cookies are set correctly, potentially
db047b7
@cacieprins
errors pkg snapshots
55fa5b1
@cacieprins
fix config tests
018816c
@cacieprins
fixing config tests
5622cc5
@cacieprins
somewhat improves tests for cors policies in packages/network
b01df45
@cacieprins
fix ts err in server-base
03f34bb
@cacieprins
refactor cypress-schematic ct spec to be less prone to timeouts
18ae100
@cacieprins
run vite-dev-server tests with injectDocumentDomain
e66d194
@cacieprins
rm document domain assertion from page_loading system test
19ce24e
@cacieprins
add system tests that test with injectDocumentDomain and others that …
3d2a0c1 
…test with cy.origin
@cacieprins
fix results_spec snapshot
edbdb36
@cacieprins
update experimentalSkipDomainInjection system test
dd9a50d
@cacieprins
different behavior for certain net_stubbing tests based on injectDocu…
70c0a8f 
…mentDomain or not
@cacieprins
fix ts
29110af
@cacieprins
extract origin key logic from remote states, for now
e1e0829
@cacieprins
move server-base and response-middleware over to new pattern
ec669b8
@cacieprins
WIP - reentry
e448022
@cacieprins
Merge branch 'release/14.0.0' into cacie/29590/document-domain-subdom…
e19fb59 
…ains
@cacieprins
fix build, remove console.log
9a1c30e
@cacieprins
check-ts
e97d548
@cacieprins
fix spec frame injection
941701f
@cacieprins
remove injection for localhost
e651ef6
@cacieprins
mostly fix vite-dev-server app integration tests
0ec1b12
@cacieprins
fix codeframe in certain cases in chrome
5de96f0
@cacieprins
drop internal stack frames from stacks intended for determining code …
0d6b14d 
…frame data
@cacieprins
some improvements to vite ct error codeframes
5afda0f
@cacieprins
fix proxy unit tests to use document domain injection util class
6cde8b9
@cacieprins
rm .only
69b7f6b
@cacieprins
fix all vite ct error specs
ddce890
@cacieprins
rm console.log
a6b486f
@cacieprins
slight refactor to util class to make easier to test
a857a38
@AtofStryker AtofStryker force-pushed the document-domain-binary branch from 9d5fc65 to ff1ee4b Compare December 16, 2024 18:49
@AtofStryker AtofStryker force-pushed the document-domain-binary branch from ff1ee4b to ce19f25 Compare December 16, 2024 19:35
@cypress Cypress
Copy link

cypress bot commented Dec 16, 2024 •
edited
Loading

cypress    Run #58997

Run Properties:  status check passed Passed #58997  •  git commit ce19f25e1b: build binary for document domain changes [run ci]
Project cypress
Branch Review document-domain-binary
Run status status check passed Passed #58997
Run duration 17m 51s
Commit git commit ce19f25e1b: build binary for document domain changes [run ci]
Committer AtofStryker
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 28
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 765
View all changes introduced in this branch ↗︎
UI Coverage  67.07%
  Untested elements 25  
  Tested elements 55  
Accessibility  96.21%
  Failed rules  0 critical   4 serious   1 moderate   0 minor
  Failed elements 198  

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brian-mann brian-mann Awaiting requested review from brian-mann brian-mann will be requested when the pull request is marked ready for review brian-mann is a code owner

@jennifer-shehane jennifer-shehane Awaiting requested review from jennifer-shehane jennifer-shehane will be requested when the pull request is marked ready for review jennifer-shehane is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AtofStryker @cacieprins