Use correct min/max stretching, and guard against flat images #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g for cell boxes outside the image
|
I also added a check for the image size matching the configured size, and a warning for cell boxes entirely outside the image. These changes all originated from the same run, |
|
The assertion on image size could be ignored if you first incorporate this PR: #354 |
|
Thank you for the PR!! This is amazing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The min/max stretching was using (im - min) / max, instead of (im - min) / (max - min). This change fixes that stretch, and also adds a small epsilon to guard against NaNs when max == min.