Login table #614
Merged
Login table #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianmcorvidae
commented
Jan 22, 2025
psarando
requested changes
Jan 22, 2025
|
I think this should have addressed all your comments now. Thanks as always for the careful reviews! |
|
Excellent, thanks for the re-review! I'll merge now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a table of recent logins to the dashboard, using the apps/terrain endpoints added elsewhere.
This appears to the right of the analysis stats, which have been cut to half-width, on larger screens, and after the analysis stats on small screens. IP addresses redacted in case it matters, but looks like this:
I'm not sure how much I like the second column for the full date, but I thought it was more readable with both the 'ago' and the full date, and with the full dates aligned with each other in the table. Open to suggestions on how to do that a bit better, but I think this basically works in any case.