Flir camera adaptor #172
Flir camera adaptor #172
Conversation
…ges. multiple() is a simple modification of snap, might not be needed.
|
Let's not make this PR only about snap methods @aduran-cz , could you rename it to Flir camera adaptor? |
…ds. Implement properties for getter/setter methods
…ce attribute. Fix bugs in image saving. Improved demo.
|
The methods here allow to take an image with the FLIR camera one or multiple times, and set exposure and gain settings. Images are saved as .jpg but this can change. Some methods are just placeholders for now. |
|
|
||
| @bitdepth.setter | ||
| def bitdepth(self, bit): | ||
| pass |
There was a problem hiding this comment.
Could you add a trigger configuration function ? and change the way camera snap an image according to the trigger mode that the camera is in ?
There was a problem hiding this comment.
can we have the trigger details implemented in another PR @YangLiujames ? so we can move forward with merging earlier
| # Release image | ||
| image_result.Release() | ||
| return True | ||
|
|
There was a problem hiding this comment.
Could you also add the support for .tiff as well as ome-zarr ? maybe add a function that just grab the data from the camera and return an array and saving can be handle outside the camera adaptor ??
There was a problem hiding this comment.
@aduran-cz you can get support for both .tiff and ome-zarr from iohub as we discussed
There was a problem hiding this comment.
I added support for .tiff with skim age.io, but not for one-zarr because PySpin uses Python 3.8 and iohub requires >= 3.9
There was a problem hiding this comment.
we will use pyspin 3.9 on windows machines(target env) so it won't be a problem to have iohub @aduran-cz but you can make a separate PR for it
…iple images with snap(). Adding bit depth and shutter mode methods.
…rray (3-dimensional for image sequences)
…rray (3-dimensional for image sequences)
There was a problem hiding this comment.
Great work @aduran-cz ! I dropped some initial comments, if you have time tomorrow @aduran-cz we can do some testing in-person and then I can continue reviewing the PR.
… to avoid redundant methods
Implemented snap() method to take and save a single frame with 1 or multiple cameras (assigned at instance creation). Tested it works with one camera.