Rename logger and make debug logging optional #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edyoshikun
approved these changes
Sep 6, 2023
There was a problem hiding this comment.
I think is a good idea especially when using copylot in other projects like mantis.
Thanks for the work @ieivanov!
|
Thanks @edyoshikun! As you see it, should we wait for anyone else to approve this before merging? |
|
@ieivanov I don't think this is a breaking change. The tests also do not depend on whether something is outputted and currently the primary users are us. Considering that the other projects (i.e Daxi, Photom,etc) are on pause and there is no other active developer we can proceed to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changed the name of the copylot logger from
applicationtocopylotand makes debug logging to a text file optional. Debug logging can be enabled with: