Allow overriding netif->input #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of statically calling ethernet_input() (which is actually defined to be ethernet_input_LWIP2), store a pointer to it in netif->input and call that. This makes it easy to hook into the processing of input packets and implement a little firewall. Of course any code doing this should save the original pointer and call it when applicable. For an example, see: https://github.com/martin-ger/esp_wifi_repeater/blob/2499913094a707b79ea4e357273a32755e31c723/user/user_main.c#L693-L697 Also remove various lines where netif->input would be reset. Set it once during netif_add(), and then trust that it wouldn't get changed without reason.
|
Not sure if I'm missing some cases here, but the resulting code looks more straight-forward and closer to upstream to me. Basic tests (including NAT, which I could then filter e.g. by target IP) went fine. |
|
@d-a-v Could you please review when you find the time? Thanks! |
|
Looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of statically calling ethernet_input() (which is actually defined to be ethernet_input_LWIP2), store a pointer to it in netif->input and call that.
This makes it easy to hook into the processing of input packets and implement a little firewall. Of course any code doing this should save the original pointer and call it when applicable. For an example, see:
https://github.com/martin-ger/esp_wifi_repeater/blob/2499913094a707b79ea4e357273a32755e31c723/user/user_main.c#L693-L697
Also remove various lines where netif->input would be reset. Set it once during netif_add(), and then trust that it wouldn't get changed without reason.