Skip to content
This repository has been archived by the owner on Oct 23, 2024. It is now read-only.

ci: change aws role #69

Merged
merged 1 commit into from
Sep 25, 2023
Merged

ci: change aws role #69

merged 1 commit into from
Sep 25, 2023

Conversation

shaeed-noordeen
Copy link
Contributor

We have decided that we no longer want our root accounts to be used in aws roles. This pr simply changes the role in the workflow. Please do not merge this repo just approve so once we change the role in aws we can merge this pr right after.
If i have missed a workflow please let me know

@shaeed-noordeen shaeed-noordeen requested a review from a team as a code owner September 25, 2023 14:16
@shaeed-noordeen shaeed-noordeen added the ready-for-review PR is ready to be reviewed label Sep 25, 2023
@MessKon
Copy link
Contributor

MessKon commented Sep 25, 2023

@shaeed-noordeen this repo has a strict commit checking CI.
it expects the commits to be in the format of:
git commit -m "fix(ci): change aws role" -m "change aws role".
you'd have to update the current commit to fit this format in order for the Pre-Commit checks ci to pass

@jonathanbeber
Copy link

@shaeed-noordeen shaeed-noordeen force-pushed the sn/change-aws-root-role branch 2 times, most recently from 577850e to 5622d1d Compare September 25, 2023 15:36
fix(ci): change aws role
@MessKon MessKon merged commit 5a1c791 into main Sep 25, 2023
4 checks passed
@MessKon MessKon deleted the sn/change-aws-root-role branch September 25, 2023 15:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ready-for-review PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants