Skip to content
This repository has been archived by the owner on Oct 23, 2024. It is now read-only.

Add dcos-autoscaler package #1030

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions repo/packages/D/dcos-autoscaler/0/config.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
{
"type": "object",
"properties": {
"cpu": {
"type": "integer",
"description": "cpu to allocate to the container",
"minimum": 0.3,
"maximum": 16,
"default": 1
},
"memory": {
"type": "integer",
"description": "Memory to allocate",
"minimum": 500,
"maximum": 9999,
"default": 1024
}
}
}
12 changes: 12 additions & 0 deletions repo/packages/D/dcos-autoscaler/0/marathon.json.mustache
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"id": "/dcos-autoscaler",
"cpus": "{{cpu}}",
"mem": "{{memory}}",
"instances": "1",
"container": {
"type": "DOCKER",
"docker": {
"image": "{{resource.assets.container.docker.23b1cfe8e04a}}"
}
}
}
11 changes: 11 additions & 0 deletions repo/packages/D/dcos-autoscaler/0/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add preInstallNotes and add this line at the beginning of preInstallNotes: This DC/OS Service is currently in preview. There may be bugs, incomplete features, incorrect documentation, or other discrepancies. Preview packages should never be used in production!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a link to dcos/examples at the end of preInstallNotes

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryadav88 done .. please review again
here is the pull request for the examples repo dcos/examples#170

"packagingVersion": "3.0",
"name": "dcos-autoscaler",
"version": "1.0.0",
"maintainer": "[email protected]",
"description": "Adds autoscaling to your application based on cpu and memory metrics",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a detailed description of what the package does, what it be used for.

"scm": "https://github.com/Ahmadposten/DC-OS-Marathon-autoscaling",
"framework": true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

framework should be false

"tags": ["autoscaling", "mesosphere", "dcos"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mesosphere tag is reserved for packages developed by Mesosphere. Please remove it.

"postInstallNotes": "Thank you for installing dcos autoscaler, Consult github.com/Ahmadposten/DC-OS-Marathon-autoscaling for more more info on usage and tuning configurations"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the license property.

}
14 changes: 14 additions & 0 deletions repo/packages/D/dcos-autoscaler/0/resource.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
{
"images": {
"icon-small": "https://drive.google.com/open?id=0BxADtivbfBMNd0VBbThQNmtkcUE",
"icon-medium": "https://drive.google.com/open?id=0BxADtivbfBMNd0VBbThQNmtkcUE",
"icon-large": "https://drive.google.com/open?id=0BxADtivbfBMNd0VBbThQNmtkcUE"
},
"assets": {
"container": {
"docker": {
"23b1cfe8e04a": "ahmadposten/dcos-autoscaler"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use a tagged version of the image

}
}
}
}