Skip to content
This repository has been archived by the owner on Oct 23, 2024. It is now read-only.

Support local volume in "registry" #1578

Closed
wants to merge 2 commits into from

Conversation

kojiha
Copy link

@kojiha kojiha commented Dec 15, 2017

The changes fix following issue to enable local volume support in "registry"

  • Fixed issue in registry storage path when persistent storage is not enabled.
    It also upgrades docker registry to 2.6.2.

… enabled.

- Updated docker registry image to 2.6.2.
@kojiha
Copy link
Author

kojiha commented Dec 18, 2017

I have posted issue #1582 for this pull-request.

@kojiha
Copy link
Author

kojiha commented Dec 22, 2017

Just to make sure that the changes are very simple, I put diff from previous revision.

diff -r repo/packages/R/registry/1/marathon.json.mustache repo/packages/R/registry/2/marathon.json.mustache
16,18c16,19
<     {{#storage.persistence.external.enable}}          
<     "STORAGE_PATH": "{{storage.storage_path}}",
<     {{/storage.persistence.external.enable}}  
---
>     {{^storage.persistence.enable}}
>     "REGISTRY_STORAGE_FILESYSTEM_ROOTDIRECTORY": "{{storage.storage_path}}",
>     {{/storage.persistence.enable}}
>     {{#storage.persistence.enable}}
21c22,23
<     {{/storage.persistence.external.enable}}  
---
>     {{/storage.persistence.external.enable}}
>     {{/storage.persistence.enable}} 
diff -r repo/packages/R/registry/1/package.json repo/packages/R/registry/2/package.json
5c5
<   "version": "2.5.1-0.2",
---
>   "version": "2.6.2-0.1",
diff -r repo/packages/R/registry/1/resource.json repo/packages/R/registry/2/resource.json
10c10
<         "registry-docker": "registry:2.5.1"
---
>         "registry-docker": "registry:2.6.2"

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants