Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow builder #29

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Flow builder #29

wants to merge 2 commits into from

Conversation

trbKnl
Copy link
Collaborator

@trbKnl trbKnl commented Dec 18, 2024

Added:

  • Flow builder
  • logs are handled in the flow builder, you can either donate logs, or dont donate logs
  • Some extra info on what files types

@paulmaxus, I implemented your builder Idea. Its flexible enough to handle anything, but its also restricted enough that you can mostly stick to the defaults.

It works as follows:

  1. You can create a flow
  2. Add steps to the flow: i.e. ask for a submit file, extract data, etc.
  3. you can string steps together, and feed output from the previous step to the next step
  4. You need to indicate, that port should render a screen, with the @yiedable decorator else it wont work

Pros:

  • Abstraction, so no code duplication, uniform handling of the flow across platforms
  • Flexible

Cons:

  • Harder to understand

What do you think about it? Feel free to make changes

Copy link
Collaborator

@paulmaxus paulmaxus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the flow design makes it much easier for us to use and extend Port with new modules. Like we discussed, combining extraction and review steps would make sense, but other than that perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants