fix: RadioGroup typing, controlled prop

daangn · Jan 15, 2025 · 64df09d · 64df09d
1 parent c8b053f
commit 64df09d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/react-headless/radio-group/src/RadioGroup.tsx b/packages/react-headless/radio-group/src/RadioGroup.tsx
@@ -46,7 +46,7 @@ RadioGroupLabel.displayName = "RadioGroupLabel";
 export interface RadioGroupItemProps
   extends RadioItemProps,
     PrimitiveProps,
-    Omit<React.InputHTMLAttributes<HTMLLabelElement>, "value"> {}
+    Omit<React.LabelHTMLAttributes<HTMLLabelElement>, "value"> {}
 
 export const RadioGroupItem = forwardRef<HTMLLabelElement, RadioGroupItemProps>((props, ref) => {
   const { value, invalid, disabled, ...otherProps } = props;
@@ -76,7 +76,7 @@ RadioGroupItemControl.displayName = "RadioGroupItemControl";
 
 export interface RadioGroupItemHiddenInputProps
   extends PrimitiveProps,
-    React.HTMLAttributes<HTMLInputElement> {}
+    React.InputHTMLAttributes<HTMLInputElement> {}
 
 export const RadioGroupItemHiddenInput = forwardRef<
   HTMLInputElement,

diff --git a/packages/react-headless/radio-group/src/useRadioGroup.ts b/packages/react-headless/radio-group/src/useRadioGroup.ts
@@ -192,7 +192,7 @@ export function useRadioGroup(props: UseRadioGroupProps) {
             }
           },
           disabled: itemState.disabled,
-          defaultChecked: itemState.checked,
+          defaultChecked: isControlled ? undefined : itemState.checked,
           checked: isControlled ? itemState.checked : undefined,
           style: visuallyHidden,
         }),