Giving more feedback when no hosts are provided #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itting `log.Fatal` into its constituent parts and adding a call to `flag.Usage()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running on Ubuntu 20.04, when I ran the exporter as
./main zk-1:2181,zk-2:2181,zk-3:2181the program would run, but fail to gather data. As someone away fromgofor a few years, it was non-obvious from the error messages that I needed to add a command-line flag.The particular pathology I experienced was the
hostarray was showinglen == 1with the first value being an empty string. I added a test for that failure case.I also split the
log.Fatalinto an explicitlog.Printandos.Exit(1)(requiring the import ofos), then added in a call to theflag.Usage()so someone else who didn't know they needed a flag would be able to see it there.Thanks for making the exporter available and I hope this PR is a helpful one!