-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Penetrating by blocks #5779
Penetrating by blocks #5779
Conversation
5ceff6f
to
6560fc2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw a few minor things, mostly related to comments, as I reviewed commit-by-commit. Several of them, and perhaps all, were fixed in later commits, so feel free to ignore any comments that apply to code that doesn't exist anymore. :)
@@ -2801,6 +2801,7 @@ private Bpl.Function GetCanCallFunction(Function f) { | |||
/// Note that SpecWellformedness and Implementation have procedure implementations | |||
/// but no callers, and vice versa for InterModuleCall, IntraModuleCall, and CoCall. | |||
/// </summary> | |||
/// Remy: TODO Simplify |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there more work on this that you want to do for this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The work was done. Now the TODO is also gone.
Description
How has this been tested?
:=,
:-
,:|
)By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.