Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Penetrating by blocks #5779

Merged

Conversation

keyboardDrummer
Copy link
Member

@keyboardDrummer keyboardDrummer commented Sep 18, 2024

Description

  • Make all by block proofs penetrate the entire LHS

How has this been tested?

  • Updated tests for call statements and the three types of assignment statements (:=, :-, :|)

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

@keyboardDrummer keyboardDrummer marked this pull request as ready for review September 24, 2024 12:12
@keyboardDrummer keyboardDrummer enabled auto-merge (squash) September 24, 2024 12:12
@keyboardDrummer keyboardDrummer requested review from robin-aws and removed request for robin-aws September 25, 2024 12:55
atomb
atomb previously approved these changes Oct 4, 2024
Copy link
Member

@atomb atomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw a few minor things, mostly related to comments, as I reviewed commit-by-commit. Several of them, and perhaps all, were fixed in later commits, so feel free to ignore any comments that apply to code that doesn't exist anymore. :)

@@ -2801,6 +2801,7 @@ private Bpl.Function GetCanCallFunction(Function f) {
/// Note that SpecWellformedness and Implementation have procedure implementations
/// but no callers, and vice versa for InterModuleCall, IntraModuleCall, and CoCall.
/// </summary>
/// Remy: TODO Simplify
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there more work on this that you want to do for this PR?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The work was done. Now the TODO is also gone.

Source/DafnyCore/AST/Grammar/TokenNewIndentCollector.cs Outdated Show resolved Hide resolved
Source/DafnyCore/AST/Statements/BlockByProofStmt.cs Outdated Show resolved Hide resolved
Source/DafnyCore/Resolver/TailRecursion.cs Outdated Show resolved Hide resolved
@keyboardDrummer keyboardDrummer merged commit c538717 into dafny-lang:master Oct 7, 2024
22 checks passed
@keyboardDrummer keyboardDrummer deleted the penetratingByBlocks branch October 7, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants