Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /v4 to references to dafny-lang/DafnyRuntimeGo #5826

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

robin-aws
Copy link
Member

@robin-aws robin-aws commented Oct 11, 2024

Description

We fixed the github.com/dafny-lang/DafnyRuntimeGo repository by adding a copy under v4/, but need to update all of the references to that path in Dafny itself.

How has this been tested?

Existing tests of Go using --go-module-name. Also added an explicit test against the published runtime, since the existing ones use replace directives to test against the local copy in DafnyRuntimeGo-gomod instead.

I also found for this test to work, I had to push a new tag on github.com/dafny-lang/DafnyRuntimeGo, since the checksum didn't match on the existing v4.7.0 tag. I suspect we moved the tag at some point when debugging the issues, which does not work since the Go checksum repository can't be updated. I went with v4.8.0 just in case it still didn't work and we needed to make extra changes and then tag with v4.8.1.

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

@robin-aws robin-aws marked this pull request as ready for review October 11, 2024 00:58
@ShubhamChaturvedi7
Copy link
Collaborator

We should have a separate integration tests which run against the published version. DafnyRuntimeGo-gomod was added because we didn't have a published library back then. We should run local tests against a copy which is generated by Dafny, and afaik DafnyRuntimeGo-gomod is static.

@robin-aws
Copy link
Member Author

We should have a separate integration tests which run against the published version. DafnyRuntimeGo-gomod was added because we didn't have a published library back then. We should run local tests against a copy which is generated by Dafny, and afaik DafnyRuntimeGo-gomod is static.

I realized this was worth doing and not hard, the only caveat was potentially needing to publish a new version of the runtime before a new version of Dafny itself, but I think that's worth it. Added a test and updated the PR description.

@robin-aws robin-aws merged commit 7f08159 into dafny-lang:master Oct 15, 2024
22 checks passed
@robin-aws robin-aws deleted the fix-go-runtime-module-path branch October 15, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants