Add /v4 to references to dafny-lang/DafnyRuntimeGo #5826
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We fixed the github.com/dafny-lang/DafnyRuntimeGo repository by adding a copy under
v4/
, but need to update all of the references to that path in Dafny itself.How has this been tested?
Existing tests of Go using
--go-module-name
. Also added an explicit test against the published runtime, since the existing ones usereplace
directives to test against the local copy inDafnyRuntimeGo-gomod
instead.I also found for this test to work, I had to push a new tag on
github.com/dafny-lang/DafnyRuntimeGo
, since the checksum didn't match on the existingv4.7.0
tag. I suspect we moved the tag at some point when debugging the issues, which does not work since the Go checksum repository can't be updated. I went withv4.8.0
just in case it still didn't work and we needed to make extra changes and then tag withv4.8.1
.By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.