Fix: --rust-module-name with externs #5865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds the ability to use `--rust-module-name` along with externs, by detecting that we are not generating an entry library file, and in that case it removes the "pub mod" declaration for the externs since side files do not have the ability to import externs themselves.
ajewellamz
previously approved these changes
Oct 28, 2024
robin-aws
approved these changes
Oct 29, 2024
MikaelMayer
added a commit
that referenced
this pull request
Oct 30, 2024
Fixes #5864 ### Description This PR adds the ability to use `--rust-module-name` along with externs, by detecting that we are not generating an entry library file, and in that case it removes the "pub mod" declaration for the externs since side files do not have the ability to import externs themselves. Since the Rust compiler is internal, we don't advertise this change yet. ### How has this been tested? The test `translate_additional/more_dafny.dfy` was updated to include externs. The test was not working without this PR, reproducing faithfully the issue. <small>By submitting this pull request, I confirm that my contribution is made under the terms of the [MIT license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5864
Description
This PR adds the ability to use
--rust-module-namealong with externs, by detecting that we are not generating an entry library file, and in that case it removes the "pub mod" declaration for the externs since side files do not have the ability to import externs themselves.Since the Rust compiler is internal, we don't advertise this change yet.
How has this been tested?
The test
translate_additional/more_dafny.dfywas updated to include externs. The test was not working without this PR, reproducing faithfully the issue.By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.