Chore: Fix cargo release for Object::from_ref #5867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR should run all deep tests and pass before being merged, so that the test cargoreleasefailurefix.dfy passes
ssomayyajula
approved these changes
Oct 29, 2024
MikaelMayer
added a commit
that referenced
this pull request
Oct 29, 2024
This PR should run all deep tests and pass before being merged, so that the test cargoreleasefailurefix.dfy passes ### Description This PR adds more black-boxing around a critical function so that the compiler won't optimize things away by for example moving the increment strong count and the assignments to `previous_strong_count`, which could have caused panicking; ### How has this been tested? All deep tests should pass, so that cargoreleasefailurefix.dfy is tested for each supported architecture <small>By submitting this pull request, I confirm that my contribution is made under the terms of the [MIT license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should run all deep tests and pass before being merged, so that the test cargoreleasefailurefix.dfy passes
Description
This PR adds more black-boxing around a critical function so that the compiler won't optimize things away by for example moving the increment strong count and the assignments to
previous_strong_count, which could have caused panicking;How has this been tested?
All deep tests should pass, so that cargoreleasefailurefix.dfy is tested for each supported architecture
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.