Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix Python virtualenv commands on Windows #5883

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

alex-chew
Copy link
Contributor

Using a virtual environment avoids polluting the system Python installation.

Reverts #5880

@alex-chew alex-chew changed the title Revert "Chore: Platform-agnostic python commands" chore: fix Python virtualenv commands on Windows Oct 31, 2024
Copy link
Member

@MikaelMayer MikaelMayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my windows machine, it works.

@alex-chew alex-chew marked this pull request as ready for review October 31, 2024 21:12
@alex-chew alex-chew enabled auto-merge (squash) October 31, 2024 21:13
@alex-chew alex-chew merged commit e410ead into master Oct 31, 2024
22 checks passed
@alex-chew alex-chew deleted the revert-5880-chore-remove-venv-windows branch October 31, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants