Fix reveal statement inside witness bug #5887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikaelMayer
reviewed
Nov 1, 2024
Source/IntegrationTests/TestFiles/LitTests/LitTest/ast/reveal/revealInBlock.dfy
Outdated
Show resolved
Hide resolved
| @@ -15,15 +14,15 @@ method RevealExpressionScope() | |||
| { | |||
| hide *; | |||
| var a := (reveal P; assert P(0); true); | |||
| assert P(1); // error | |||
| assert P(1); // no error, expression leaks. | |||
There was a problem hiding this comment.
I hope one day it will be clear enough why it leaks, or it will be the default that it does not leak unless the reveal itself is marked explicitly as leaking.
There was a problem hiding this comment.
I'm still hoping the remove the need for expression statements, but we'll see whether that's possible and desired.
| @@ -0,0 +1 @@ | |||
| Enable using reveal statement expression inside witness expressions | |||
There was a problem hiding this comment.
Suggested change
| Enable using reveal statement expression inside witness expressions | |
| Enable using reveal statement expression inside witness expressions when the new resolver is activated with `--type-system-refresh` |
There was a problem hiding this comment.
I removed this limitation in a previous PR
…revealInBlock.dfy Co-authored-by: Mikaël Mayer <[email protected]>
MikaelMayer
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5882
How has this been tested?
CLI test added
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.