Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add version tests #153

Merged
merged 2 commits into from
Oct 25, 2024
Merged

test: add version tests #153

merged 2 commits into from
Oct 25, 2024

Conversation

jedevc
Copy link
Member

@jedevc jedevc commented Oct 14, 2024

This PR adds some basic versioning tests to confirm the new behavior added in #151.

To do this, we add outputs to the action to be able to easily capture the stdout of the call to the dagger binary.

Then we can add some github workflows to check that the version parameter is working as desired.

You can see an example run in https://github.com/jedevc/dagger-for-github/actions/runs/11331238930/job/31510817051.

@jedevc jedevc requested review from gerhard and jpadams October 14, 2024 16:14
@jedevc jedevc force-pushed the add-version-tests branch 2 times, most recently from 88d6b6e to 4f2024d Compare October 21, 2024 12:25
Signed-off-by: Justin Chadwell <[email protected]>
To chain on from the github action, it's very useful to be able to get
the output from an action.

Signed-off-by: Justin Chadwell <[email protected]>
@jedevc jedevc force-pushed the add-version-tests branch from 4f2024d to 1a00b8f Compare October 25, 2024 15:04
Copy link
Member

@gerhard gerhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 🚀

@gerhard gerhard merged commit 33170d0 into dagger:main Oct 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants