-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alias args to call and make call optional #162
Conversation
Signed-off-by: kpenfound <[email protected]>
Signed-off-by: kpenfound <[email protected]>
Signed-off-by: kpenfound <[email protected]>
Signed-off-by: kpenfound <[email protected]>
Signed-off-by: kpenfound <[email protected]>
with: | ||
module: github.com/shykes/daggerverse/[email protected] | ||
call: hello | ||
- name: "Test call (check)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test case is in the version
job - just for clarity, either it should be in a different job, or we could rename this job to something else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I can rename it. I didn't realize the workflow was called version, I just saw test.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Agree to add new job
Signed-off-by: kpenfound <[email protected]>
Signed-off-by: kpenfound <[email protected]>
Discussed in person. We'd like to:
dagger call foo
in bash steps manuallycall
toargs
so that we can saycall: hello
instead ofargs: hello