Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alias args to call and make call optional #162

Merged
merged 7 commits into from
Nov 11, 2024

Conversation

kpenfound
Copy link
Contributor

Discussed in person. We'd like to:

  • Make args optional, so if I don't pass args (or call) we can just use the action to install dagger and run dagger call foo in bash steps manually
  • alias call to args so that we can say call: hello instead of args: hello

@kpenfound kpenfound requested review from jpadams and levlaz November 11, 2024 05:47
with:
module: github.com/shykes/daggerverse/[email protected]
call: hello
- name: "Test call (check)"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test case is in the version job - just for clarity, either it should be in a different job, or we could rename this job to something else?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I can rename it. I didn't realize the workflow was called version, I just saw test.yml

Copy link
Contributor

@jpadams jpadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Agree to add new job

@kpenfound kpenfound merged commit e3a863e into dagger:main Nov 11, 2024
4 checks passed
@kpenfound kpenfound deleted the optional_call branch November 11, 2024 17:21
@jedevc jedevc mentioned this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants