[dagster-powerbi][fix] Gracefully handle reports with no dataset (#26031

) ## Summary Gracefully handles the case where a report doesn't have a dependency on a dataset specified. ## How I Tested These Changes New unit test. ## Changelog > [dagster-powerbi] Fixed an issue where reports without an upstream dataset dependency would fail to translate to an asset spec.
dagster-io · Nov 20, 2024 · 026d5cd · 026d5cd
1 parent ec82b0e
commit 026d5cd
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 3 deletions.
diff --git a/python_modules/libraries/dagster-powerbi/dagster_powerbi/translator.py b/python_modules/libraries/dagster-powerbi/dagster_powerbi/translator.py
@@ -208,8 +208,10 @@ def get_report_asset_key(self, data: PowerBIContentData) -> AssetKey:
 
     def get_report_spec(self, data: PowerBIContentData) -> AssetSpec:
         report_id = data.properties["id"]
-        dataset_id = data.properties["datasetId"]
-        dataset_data = self.workspace_data.semantic_models_by_id.get(dataset_id)
+        dataset_id = data.properties.get("datasetId")
+        dataset_data = (
+            self.workspace_data.semantic_models_by_id.get(dataset_id) if dataset_id else None
+        )
         dataset_key = self.get_semantic_model_asset_key(dataset_data) if dataset_data else None
         url = (
             data.properties.get("webUrl")

diff --git a/python_modules/libraries/dagster-powerbi/dagster_powerbi_tests/test_translator.py b/python_modules/libraries/dagster-powerbi/dagster_powerbi_tests/test_translator.py
@@ -4,7 +4,7 @@
 from dagster._core.definitions.metadata.table import TableColumn, TableSchema
 from dagster._core.definitions.tags import build_kind_tag
 from dagster_powerbi import DagsterPowerBITranslator
-from dagster_powerbi.translator import PowerBIContentData, PowerBIWorkspaceData
+from dagster_powerbi.translator import PowerBIContentData, PowerBIContentType, PowerBIWorkspaceData
 
 
 def test_translator_dashboard_spec(workspace_data: PowerBIWorkspaceData) -> None:
@@ -129,3 +129,28 @@ def test_translator_custom_metadata(workspace_data: PowerBIWorkspaceData) -> Non
 
     assert asset_spec.metadata == {"custom": "metadata"}
     assert asset_spec.key.path == ["dashboard", "Sales_Returns_Sample_v201912"]
+
+
+def test_translator_report_spec_no_dataset(workspace_data: PowerBIWorkspaceData) -> None:
+    report_no_dataset = PowerBIContentData(
+        content_type=PowerBIContentType.REPORT,
+        properties={
+            "id": "8b7f815d-4e64-40dd-993c-cfa4fb12edee",
+            "reportType": "PowerBIReport",
+            "name": "Sales & Returns Sample v201912",
+            "webUrl": "https://app.powerbi.com/groups/a2122b8f-d7e1-42e8-be2b-a5e636ca3221/reports/8b7f815d-4e64-40dd-993c-cfa4fb12edee",
+            "embedUrl": "https://app.powerbi.com/reportEmbed?reportId=8b7f815d-4e64-40dd-993c-cfa4fb12edee&groupId=a2122b8f-d7e1-42e8-be2b-a5e636ca3221&w=2&config=eyJjbHVzdGVyVXJsIjoiaHR0cHM6Ly9XQUJJLVdFU1QtVVMtRS1QUklNQVJZLXJlZGlyZWN0LmFuYWx5c2lzLndpbmRvd3MubmV0IiwiZW1iZWRGZWF0dXJlcyI6eyJ1c2FnZU1ldHJpY3NWTmV4dCI6dHJ1ZX19",
+            "isFromPbix": True,
+            "isOwnedByMe": True,
+            "users": [],
+            "subscriptions": [],
+            "createdBy": "[email protected]",
+        },
+    )
+
+    translator = DagsterPowerBITranslator(workspace_data)
+    asset_spec = translator.get_asset_spec(report_no_dataset)
+
+    assert asset_spec.key.path == ["report", "Sales_Returns_Sample_v201912"]
+    deps = list(asset_spec.deps)
+    assert len(deps) == 0