Skip to content

Commit

Permalink
Move types-sqlalchemy to requirements.txt (#25760)
Browse files Browse the repository at this point in the history
Move types-sqlalchemy into managed pyright environment

## Summary & Motivation

If you're using sqlalchemy 2, then this type package is no longer correctly representing the sqlalchemy types. This change moves the pinned package into the managed pyright environment instead of being in the pyright extra.

## How I Tested These Changes

make pyright

## Changelog

The `types-sqlalchemy` package is no longer included in the `dagster[pyright]` extra package.
  • Loading branch information
sbquinlan authored Nov 6, 2024
1 parent b7dafbd commit 0d1953b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 2 additions & 0 deletions pyright/master/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,8 @@ wordcloud # (quickstart-*)
# that trigger type errors
apache-airflow>2.7
pendulum<3
types-sqlalchemy==1.4.53.34


### EXAMPLES

Expand Down
1 change: 0 additions & 1 deletion python_modules/dagster/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,6 @@ def get_version() -> str:
"types-requests", # version will be resolved against requests
"types-simplejson", # version will be resolved against simplejson
"types-six", # needed but not specified by grpcio
"types-sqlalchemy==1.4.53.34", # later versions introduce odd errors
"types-tabulate", # version will be resolved against tabulate
"types-tzlocal", # version will be resolved against tzlocal
"types-toml", # version will be resolved against toml
Expand Down

0 comments on commit 0d1953b

Please sign in to comment.