feedback + rebase

dagster-io · Oct 6, 2023 · 16b856b · 16b856b
1 parent fa542cc
commit 16b856b
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 18 deletions.
diff --git a/...ges/ui-core/src/assets/auto-materialization/AutomaterializationEvaluationHistoryTable.tsx b/...ges/ui-core/src/assets/auto-materialization/AutomaterializationEvaluationHistoryTable.tsx
@@ -137,7 +137,6 @@ export const AutomaterializationEvaluationHistoryTable = ({
             <th>Status</th>
             <th>Duration</th>
             <th>Result</th>
-            <th></th>
           </tr>
         </thead>
         <tbody>
@@ -173,15 +172,6 @@ export const AutomaterializationEvaluationHistoryTable = ({
                   ' - '
                 )}
               </td>
-              <td>
-                <Button
-                  onClick={() => {
-                    setSelectedTick(tick);
-                  }}
-                >
-                  View details
-                </Button>
-              </td>
             </tr>
           ))}
         </tbody>

diff --git a/.../packages/ui-core/src/assets/auto-materialization/AutomaterializationTickDetailDialog.tsx b/.../packages/ui-core/src/assets/auto-materialization/AutomaterializationTickDetailDialog.tsx
@@ -219,7 +219,11 @@ export const AutomaterializationTickDetailDialog = React.memo(
                   <Subtitle2>Status</Subtitle2>
                   <Box flex={{direction: 'row', gap: 4, alignItems: 'center'}}>
                     <Tag intent={intent}>
-                      {tick?.requestedAssetMaterializationCount ?? 0} requested
+                      {tick?.status === InstigationTickStatus.STARTED ? (
+                        'Evaluating…'
+                      ) : (
+                        <>{tick?.requestedAssetMaterializationCount ?? 0} requested</>
+                      )}
                     </Tag>
                     {tick?.error ? (
                       <ButtonLink
@@ -246,13 +250,17 @@ export const AutomaterializationTickDetailDialog = React.memo(
                 </Box>
               </div>
             </Box>
-            <Box
-              padding={{vertical: 12, horizontal: 24}}
-              border={filteredAssetKeys.length > 0 ? undefined : 'bottom'}
-            >
-              <Subtitle2>Materializations requested</Subtitle2>
-            </Box>
-            {content}
+            {tick?.status === InstigationTickStatus.STARTED ? null : (
+              <>
+                <Box
+                  padding={{vertical: 12, horizontal: 24}}
+                  border={filteredAssetKeys.length > 0 ? undefined : 'bottom'}
+                >
+                  <Subtitle2>Materializations requested</Subtitle2>
+                </Box>
+                {content}
+              </>
+            )}
           </div>
         }
       />