client side feature flag instead

dagster-io · Oct 9, 2023 · 1ceb3ac · 1ceb3ac
1 parent cc70012
commit 1ceb3ac
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 17 deletions.
diff --git a/js_modules/dagster-ui/packages/ui-core/src/app/CloudFeatureFlag.tsx b/js_modules/dagster-ui/packages/ui-core/src/app/CloudFeatureFlag.tsx
diff --git a/js_modules/dagster-ui/packages/ui-core/src/app/Flags.tsx b/js_modules/dagster-ui/packages/ui-core/src/app/Flags.tsx
@@ -16,6 +16,7 @@ export const FeatureFlag = {
   flagDisableAutoLoadDefaults: 'flagDisableAutoLoadDefaults' as const,
   flagDAGSidebar: 'flagDAGSidebar' as const,
   flagDisableDAGCache: 'flagDisableDAGCache' as const,
+  flagEnableAMPTimeline: 'flagEnableAMPTimeline' as const,
 };
 export type FeatureFlagType = keyof typeof FeatureFlag;
 

diff --git a/js_modules/dagster-ui/packages/ui-core/src/app/getVisibleFeatureFlagRows.tsx b/js_modules/dagster-ui/packages/ui-core/src/app/getVisibleFeatureFlagRows.tsx
@@ -57,4 +57,8 @@ export const getVisibleFeatureFlagRows = () => [
     key: 'Disable Asset Graph caching',
     flagType: FeatureFlag.flagDisableDAGCache,
   },
+  {
+    key: 'Experimental Auto-materialize policy timeline page',
+    flagType: FeatureFlag.flagEnableAMPTimeline,
+  },
 ];
diff --git a/js_modules/dagster-ui/packages/ui-core/src/overview/OverviewRoot.tsx b/js_modules/dagster-ui/packages/ui-core/src/overview/OverviewRoot.tsx
@@ -1,7 +1,7 @@
 import * as React from 'react';
 import {Redirect, Route, Switch} from 'react-router-dom';
 
-import {useCloudFeatureFlag} from '../app/CloudFeatureFlag';
+import {useFeatureFlags} from '../app/Flags';
 import {AutomaterializationRoot} from '../assets/auto-materialization/AutomaterializationRoot';
 import {InstanceBackfills} from '../instance/InstanceBackfills';
 import {BackfillPage} from '../instance/backfill/BackfillPage';
@@ -13,7 +13,7 @@ import {OverviewSchedulesRoot} from './OverviewSchedulesRoot';
 import {OverviewSensorsRoot} from './OverviewSensorsRoot';
 
 export const OverviewRoot = () => {
-  const {enableAMPTimeline} = useCloudFeatureFlag();
+  const {flagEnableAMPTimeline} = useFeatureFlags();
   return (
     <Switch>
       <Route path="/overview/activity">
@@ -28,7 +28,7 @@ export const OverviewRoot = () => {
       <Route path="/overview/sensors">
         <OverviewSensorsRoot />
       </Route>
-      {enableAMPTimeline ? (
+      {flagEnableAMPTimeline ? (
         <Route path="/overview/amp">
           <AutomaterializationRoot />
         </Route>

diff --git a/js_modules/dagster-ui/packages/ui-core/src/overview/OverviewTabs.tsx b/js_modules/dagster-ui/packages/ui-core/src/overview/OverviewTabs.tsx
@@ -2,7 +2,7 @@ import {QueryResult} from '@apollo/client';
 import {Box, Colors, Spinner, Tabs} from '@dagster-io/ui-components';
 import * as React from 'react';
 
-import {useCloudFeatureFlag} from '../app/CloudFeatureFlag';
+import {useFeatureFlags} from '../app/Flags';
 import {QueryRefreshCountdown, QueryRefreshState} from '../app/QueryRefresh';
 import {useAutomaterializeDaemonStatus} from '../assets/AutomaterializeDaemonStatusTag';
 import {TabLink} from '../ui/TabLink';
@@ -17,7 +17,7 @@ export const OverviewTabs = <TData extends Record<string, any>>(props: Props<TDa
   const {refreshState, tab} = props;
 
   const automaterialize = useAutomaterializeDaemonStatus();
-  const {enableAMPTimeline} = useCloudFeatureFlag();
+  const {flagEnableAMPTimeline} = useFeatureFlags();
 
   return (
     <Box flex={{direction: 'row', justifyContent: 'space-between', alignItems: 'flex-end'}}>
@@ -26,7 +26,7 @@ export const OverviewTabs = <TData extends Record<string, any>>(props: Props<TDa
         <TabLink id="jobs" title="Jobs" to="/overview/jobs" />
         <TabLink id="schedules" title="Schedules" to="/overview/schedules" />
         <TabLink id="sensors" title="Sensors" to="/overview/sensors" />
-        {enableAMPTimeline ? (
+        {flagEnableAMPTimeline ? (
           <TabLink
             id="amp"
             title={