Skip to content

Commit

Permalink
[dagster-dbt] Subclass typing.Iterator in DbtEventIterator (#26424)
Browse files Browse the repository at this point in the history
## Summary & Motivation

Subclass `typing.Iterator` instead of `abc.Iterator` in
`DbtEventIterator`. This is motivated by [this
discussion](#26396 (comment)).

## How I Tested These Changes

Same tests with BK
  • Loading branch information
maximearmstrong authored Dec 12, 2024
1 parent 59aaaed commit 303625c
Showing 1 changed file with 1 addition and 2 deletions.
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
from collections import abc
from concurrent.futures import ThreadPoolExecutor
from typing import TYPE_CHECKING, Any, Callable, Dict, Generic, Iterator, Optional, Union, cast

Expand Down Expand Up @@ -186,7 +185,7 @@ def _fetch_row_count_metadata(
return None


class DbtEventIterator(Generic[T], abc.Iterator):
class DbtEventIterator(Generic[T], Iterator):
"""A wrapper around an iterator of dbt events which contains additional methods for
post-processing the events, such as fetching row counts for materialized tables.
"""
Expand Down

0 comments on commit 303625c

Please sign in to comment.