-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[docs] - Asset selection syntax updates (#18041)
## Summary & Motivation This PR cleans up the Asset selection guide and adds links to the guide elsewhere in the docs. Specifically: - Adds section headings to syntax guide - Puts the syntax/usage reference into a table - Adds an expanded **Examples** section. For each scenario, added examples in Python, the CLI, and the Dagster UI. I opted to do this because there seemed to be (at least during my testing) subtle differences in syntax for each approach. Also, visuals can help make it clear what to expect for different queries. **Before**: ![Screenshot 2023-11-16 at 10 45 12 AM](https://github.com/dagster-io/dagster/assets/16615212/eb0d2f26-0484-4e18-9e3b-4c2d02992df5) **After**: ![Screenshot 2023-11-16 at 10 45 32 AM](https://github.com/dagster-io/dagster/assets/16615212/d1428eec-7f96-413d-87f9-3d540b3201c8) ![Screenshot 2023-11-16 at 10 49 30 AM](https://github.com/dagster-io/dagster/assets/16615212/1c1bc02a-8589-4fc9-bb1b-566f835ac65b) ## How I Tested These Changes 👀 , DU project + CLI, UI, Python
- Loading branch information
1 parent
32ce8a7
commit 30881ea
Showing
11 changed files
with
554 additions
and
23 deletions.
There are no files selected for viewing
575 changes: 552 additions & 23 deletions
575
docs/content/concepts/assets/asset-selection-syntax.mdx
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+332 KB
...xt/public/images/concepts/assets/asset-selection/asset-selection-syntax-dag.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+222 KB
...xt/public/images/concepts/assets/asset-selection/select-disjointed-lineages.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+286 KB
...ublic/images/concepts/assets/asset-selection/select-downstream-dependencies.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+285 KB
docs/next/public/images/concepts/assets/asset-selection/select-entire-lineage.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+201 KB
...xt/public/images/concepts/assets/asset-selection/select-multiple-components.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+192 KB
docs/next/public/images/concepts/assets/asset-selection/select-single-asset.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+273 KB
.../public/images/concepts/assets/asset-selection/select-two-downstream-layers.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+284 KB
...xt/public/images/concepts/assets/asset-selection/select-two-upstream-layers.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+304 KB
.../public/images/concepts/assets/asset-selection/select-upstream-dependencies.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
30881ea
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deploy preview for dagster-docs ready!
✅ Preview
https://dagster-docs-6yoykimfq-elementl.vercel.app
https://master.dagster.dagster-docs.io
Built with commit 30881ea.
This pull request is being automatically deployed with vercel-action