Skip to content

Commit

Permalink
[docs] - Asset selection syntax updates (#18041)
Browse files Browse the repository at this point in the history
## Summary & Motivation

This PR cleans up the Asset selection guide and adds links to the guide
elsewhere in the docs. Specifically:

- Adds section headings to syntax guide
- Puts the syntax/usage reference into a table
- Adds an expanded **Examples** section. For each scenario, added
examples in Python, the CLI, and the Dagster UI. I opted to do this
because there seemed to be (at least during my testing) subtle
differences in syntax for each approach. Also, visuals can help make it
clear what to expect for different queries.

**Before**:

![Screenshot 2023-11-16 at 10 45 12
AM](https://github.com/dagster-io/dagster/assets/16615212/eb0d2f26-0484-4e18-9e3b-4c2d02992df5)


**After**:

![Screenshot 2023-11-16 at 10 45 32
AM](https://github.com/dagster-io/dagster/assets/16615212/d1428eec-7f96-413d-87f9-3d540b3201c8)
![Screenshot 2023-11-16 at 10 49 30
AM](https://github.com/dagster-io/dagster/assets/16615212/1c1bc02a-8589-4fc9-bb1b-566f835ac65b)

## How I Tested These Changes

👀 , DU project + CLI, UI, Python
  • Loading branch information
erinkcochran87 authored Nov 16, 2023
1 parent 32ce8a7 commit 30881ea
Show file tree
Hide file tree
Showing 11 changed files with 554 additions and 23 deletions.
575 changes: 552 additions & 23 deletions docs/content/concepts/assets/asset-selection-syntax.mdx

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions docs/content/concepts/assets/software-defined-assets.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -402,6 +402,8 @@ To view a graph of all assets and their dependencies, you can:
- Click **View global asset lineage** in the [**Asset catalog**](#asset-catalog)
- Click the **Lineage tab** in the [**Asset details** page](#asset-details)

To show a subset of assets in the graph, use the **search bar** next to the **Filter** button. Refer to the [Asset selection syntax reference](/concepts/assets/asset-selection-syntax) for more info and examples using the query syntax.

<!-- ![Asset lineage graph](/images/concepts/webserver/global-asset-lineage.png) -->

<Image
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

1 comment on commit 30881ea

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy preview for dagster-docs ready!

✅ Preview
https://dagster-docs-6yoykimfq-elementl.vercel.app
https://master.dagster.dagster-docs.io

Built with commit 30881ea.
This pull request is being automatically deployed with vercel-action

Please sign in to comment.