-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[ui] Update DA evaluation page to show backfill in table if a backfil…
…l was requested (#26643) ## Summary & Motivation The runs table for a DA evaluation was not showing backfills when DA requested a backfill <img width="1440" alt="Screenshot 2024-12-20 at 10 55 57 AM" src="https://github.com/user-attachments/assets/e38e5598-4e35-4219-a0de-9228b99d595e" /> This is because the the `selectedEvaluation.runIds` could be run ids or a backfill id, but we were always adding them as run id filters. Then the value was a backfill id, it would return no results. This add some (admittedly a bit hacky) logic to determine if the id is a backfill id, and set the correct filter if so. A more long term solution would be to store run ids and backfill ids as separate lists on the evaluation, but this will fix the problem until we can make the more sustainable change. <img width="1440" alt="Screenshot 2024-12-20 at 11 18 30 AM" src="https://github.com/user-attachments/assets/2541bb18-b011-49d9-b271-56f5f022cf64" /> I also had to update the `RunsFeedTableWithFilters` component to take a bool `includeRunsFromBackfills` so that we would only show the backfill row, not the runs that the backfill launched. I had to then update all of the users of `RunsFeedTableWithFilters` to pass the bool ## How I Tested These Changes 👀 ## Changelog [ui] Fixed a bug where backfills launched by Declarative Automation were not being shown in the table of launched runs.
- Loading branch information
1 parent
8c4f449
commit 37f2042
Showing
8 changed files
with
34 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37f2042
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deploy preview for dagit-core-storybook ready!
✅ Preview
https://dagit-core-storybook-mqhc79msx-elementl.vercel.app
Built with commit 37f2042.
This pull request is being automatically deployed with vercel-action