Skip to content

Commit

Permalink
[docs] Updating BD guide to use actual GHA arg name (#19276)
Browse files Browse the repository at this point in the history
## Summary & Motivation
Context: https://dagsterlabs.slack.com/archives/C03E60FPJCU/p1705552397002939

Looks like the GHA was updated over a year ago to use an explicit `job_name` arg rather than the `job` arg and the docs weren't updated. Swapping to `job_name` to reflect the state of the github action

## How I Tested These Changes
  • Loading branch information
tacastillo authored Jan 18, 2024
1 parent 7376484 commit 44a4e77
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions docs/content/guides/dagster/branch_deployments.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,7 @@ name: Dagster Branch Deployments
with:
location_name: ${{ matrix.location.name }}
deployment: ${{ steps.deploy.outputs.deployment }}
job: clone_prod
job_name: clone_prod
env:
DAGSTER_CLOUD_URL: ${{ secrets.DAGSTER_CLOUD_URL }}
DAGSTER_CLOUD_API_TOKEN: ${{ secrets.DAGSTER_CLOUD_API_TOKEN }}
Expand Down Expand Up @@ -437,7 +437,7 @@ name: Dagster Branch Deployments
with:
location_name: ${{ matrix.location.name }}
deployment: ${{ steps.deploy.outputs.deployment }}
job: drop_prod_clone
job_name: drop_prod_clone
env:
DAGSTER_CLOUD_URL: ${{ secrets.DAGSTER_CLOUD_URL }}
DAGSTER_CLOUD_API_TOKEN: ${{ secrets.DAGSTER_CLOUD_API_TOKEN }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ name: Dagster Branch Deployments
with:
location_name: ${{ matrix.location.name }}
deployment: ${{ steps.deploy.outputs.deployment }}
job: clone_prod
job_name: clone_prod
env:
DAGSTER_CLOUD_URL: ${{ secrets.DAGSTER_CLOUD_URL }}
DAGSTER_CLOUD_API_TOKEN: ${{ secrets.DAGSTER_CLOUD_API_TOKEN }}
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ name: Dagster Branch Deployments
with:
location_name: ${{ matrix.location.name }}
deployment: ${{ steps.deploy.outputs.deployment }}
job: drop_prod_clone
job_name: drop_prod_clone
env:
DAGSTER_CLOUD_URL: ${{ secrets.DAGSTER_CLOUD_URL }}
DAGSTER_CLOUD_API_TOKEN: ${{ secrets.DAGSTER_CLOUD_API_TOKEN }}

1 comment on commit 44a4e77

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy preview for dagster-docs ready!

✅ Preview
https://dagster-docs-j0enxkcz7-elementl.vercel.app
https://master.dagster.dagster-docs.io

Built with commit 44a4e77.
This pull request is being automatically deployed with vercel-action

Please sign in to comment.