-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[1.8][external assets] remove
external_assets_from_specs
from conce…
…pt docs (#23200) ## Summary & Motivation Replaces them with direct usage of `AssetSpec`, which is enabled by #22961. ## How I Tested These Changes
- Loading branch information
Showing
6 changed files
with
20 additions
and
40 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
examples/docs_snippets/docs_snippets/concepts/assets/external_assets/external_asset_deps.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
from dagster import AssetSpec, Definitions, external_assets_from_specs | ||
from dagster import AssetSpec, Definitions | ||
|
||
raw_logs = AssetSpec("raw_logs") | ||
processed_logs = AssetSpec("processed_logs", deps=[raw_logs]) | ||
|
||
defs = Definitions(assets=external_assets_from_specs([raw_logs, processed_logs])) | ||
defs = Definitions(assets=[raw_logs, processed_logs]) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
examples/docs_snippets/docs_snippets/concepts/assets/external_assets/single_declaration.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
from dagster import AssetSpec, Definitions, external_asset_from_spec | ||
from dagster import AssetSpec, Definitions | ||
|
||
defs = Definitions(assets=[external_asset_from_spec(AssetSpec("file_in_s3"))]) | ||
defs = Definitions(assets=[AssetSpec("file_in_s3")]) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
54dd213
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deploy preview for dagster-docs ready!
✅ Preview
https://dagster-docs-kakaouboh-elementl.vercel.app
https://master.dagster.dagster-docs.io
Built with commit 54dd213.
This pull request is being automatically deployed with vercel-action