-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[ui] Offer to materialize changed and missing on asset list views (#1…
…8722) When we revamped the data loading in the global asset graph, we limited the “materialize changed and missing” to specific contexts (#18198). I think that it makes sense to show this option whenever more than one asset is in scope, whether you’re operating on an all assets in view or on a selection. This PR reverts a bit of #18198 so it appears here: <img width="1727" alt="image" src="https://github.com/dagster-io/dagster/assets/1037212/5d1df552-dcd1-4d05-93d7-6d16f320637b"> Previously, we disabled this option when `scope=selection` because there was no confirmation modal and it was confusing whether it was "changed and missing and in your selection" or not. Now that we have a nice modal with checkboxes for revising + confirming the subset that will materialize, it’s no longer confusing and we should offer it in this case. I audited all the callsites where we use the LaunchAssetExecutionButton, and I think the only place we don’t want to show this option is on the individual asset view. To make sure this doesn’t get left out again, I inverted the option from “showChangedAndMissingOption” (show option) to “scopeAlwaysSingleAsset” (hide option) and set it in just that one place. ## How I Tested These Changes I verified the existing tests covering the launch button still pass, and tested these changes manually in the graph and list view. --------- Co-authored-by: bengotow <[email protected]>
- Loading branch information
Showing
5 changed files
with
8 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
64a1fa7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deploy preview for dagit-core-storybook ready!
✅ Preview
https://dagit-core-storybook-gx025wvju-elementl.vercel.app
Built with commit 64a1fa7.
This pull request is being automatically deployed with vercel-action