Skip to content

Commit

Permalink
Fix cache key for asset graph (#17049)
Browse files Browse the repository at this point in the history
## Summary & Motivation

We should be using the node IDs as part of the cache key, not the keys
of GraphData (which would be the same for every graph)

## How I Tested These Changes

Locally checked that two graphs with no upstream/downstreams had
different graphs
  • Loading branch information
salazarm authored Oct 5, 2023
1 parent 2c2d370 commit 66c675a
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ const _assetLayoutCacheKey = (graphData: GraphData) => {
return JSON.stringify({
downstream: recreateObjectWithKeysSorted(graphData.downstream),
upstream: recreateObjectWithKeysSorted(graphData.upstream),
nodes: Object.keys(graphData).sort(),
nodes: Object.keys(graphData.nodes).sort(),
});
};

Expand Down

1 comment on commit 66c675a

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-8a616ivxd-elementl.vercel.app

Built with commit 66c675a.
This pull request is being automatically deployed with vercel-action

Please sign in to comment.