convert to metadata type

dagster-io · Apr 29, 2024 · 6b3d071 · 6b3d071
1 parent 1a88fee
commit 6b3d071
Show file tree

Hide file tree

Showing 33 changed files with 2,555 additions and 29 deletions.
diff --git a/js_modules/dagster-ui/packages/ui-core/src/asset-graph/types/AssetGraphJobSidebar.types.ts b/js_modules/dagster-ui/packages/ui-core/src/asset-graph/types/AssetGraphJobSidebar.types.ts
diff --git a/js_modules/dagster-ui/packages/ui-core/src/asset-graph/types/SidebarAssetInfo.types.ts b/js_modules/dagster-ui/packages/ui-core/src/asset-graph/types/SidebarAssetInfo.types.ts
diff --git a/js_modules/dagster-ui/packages/ui-core/src/assets/AssetView.tsx b/js_modules/dagster-ui/packages/ui-core/src/assets/AssetView.tsx
@@ -50,9 +50,9 @@ import {
 } from '../asset-graph/Utils';
 import {useAssetGraphData} from '../asset-graph/useAssetGraphData';
 import {StaleReasonsTag} from '../assets/Stale';
-import {CodeLink, CodeLinkData} from '../code-links/CodeLink';
+import {CodeLink} from '../code-links/CodeLink';
 import {AssetComputeKindTag} from '../graph/OpTags';
-import {JsonMetadataEntry} from '../graphql/types';
+import {SourceMetadataEntry} from '../graphql/types';
 import {useQueryPersistedState} from '../hooks/useQueryPersistedState';
 import {isCanonicalCodeSourceEntry} from '../metadata/TableSchema';
 import {RepositoryLink} from '../nav/RepositoryLink';
@@ -280,11 +280,8 @@ export const AssetView = ({assetKey, trace, headerBreadcrumbs}: Props) => {
 
   const assetMetadata = definition && metadataForAssetNode(definition).assetMetadata;
   const codeSource = assetMetadata?.find((m) => isCanonicalCodeSourceEntry(m)) as
-    | JsonMetadataEntry
+    | SourceMetadataEntry
     | undefined;
-  const codeSourceUrlsData = codeSource
-    ? (JSON.parse(codeSource.jsonString) as CodeLinkData)
-    : undefined;
 
   return (
     <Box
@@ -311,8 +308,8 @@ export const AssetView = ({assetKey, trace, headerBreadcrumbs}: Props) => {
         }
         right={
           <Box style={{margin: '-4px 0'}} flex={{direction: 'row', gap: 8}}>
-            {codeSourceUrlsData && Object.keys(codeSourceUrlsData).length > 0 && (
-              <CodeLink codeLinkData={codeSourceUrlsData} />
+            {codeSource && Object.keys(codeSource.sources).length > 0 && (
+              <CodeLink codeLinkData={codeSource} />
             )}
             {definition && definition.isObservable ? (
               <LaunchAssetObservationButton

diff --git a/.../packages/ui-core/src/assets/AutoMaterializePolicyPage/types/GetEvaluationsQuery.types.ts b/.../packages/ui-core/src/assets/AutoMaterializePolicyPage/types/GetEvaluationsQuery.types.ts
diff --git a/.../dagster-ui/packages/ui-core/src/assets/asset-checks/types/AssetCheckDetailModal.types.ts b/.../dagster-ui/packages/ui-core/src/assets/asset-checks/types/AssetCheckDetailModal.types.ts
diff --git a/js_modules/dagster-ui/packages/ui-core/src/assets/asset-checks/types/AssetChecks.types.ts b/js_modules/dagster-ui/packages/ui-core/src/assets/asset-checks/types/AssetChecks.types.ts
diff --git a/...ter-ui/packages/ui-core/src/assets/asset-checks/types/VirtualizedAssetCheckTable.types.ts b/...ter-ui/packages/ui-core/src/assets/asset-checks/types/VirtualizedAssetCheckTable.types.ts
diff --git a/...gster-ui/packages/ui-core/src/assets/lineage/types/useColumnLineageDataForAssets.types.ts b/...gster-ui/packages/ui-core/src/assets/lineage/types/useColumnLineageDataForAssets.types.ts