add test

dagster-io · Nov 16, 2023 · 6ea0de0 · 6ea0de0
1 parent 8b656d4
commit 6ea0de0
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/python_modules/dagster/dagster/_core/definitions/time_window_partitions.py b/python_modules/dagster/dagster/_core/definitions/time_window_partitions.py
@@ -1868,7 +1868,7 @@ def with_partitions_def(
         )
 
     def __repr__(self) -> str:
-        return f"PartitionKeysTimeWindowPartitionsSubset({self.get_partition_key_ranges()})"
+        return f"PartitionKeysTimeWindowPartitionsSubset({self.get_partition_key_ranges(self.partitions_def)})"
 
 
 class TimeWindowPartitionsSubsetSerializer(NamedTupleSerializer):

diff --git a/python_modules/dagster/dagster_tests/core_tests/partition_tests/test_partition.py b/python_modules/dagster/dagster_tests/core_tests/partition_tests/test_partition.py
@@ -16,6 +16,7 @@
 )
 from dagster._check import CheckError
 from dagster._core.test_utils import instance_for_test
+from dagster._serdes import serialize_value
 
 
 @pytest.mark.parametrize(
@@ -155,9 +156,12 @@ def test_static_partitions_subset_identical_serialization():
     # serialized subsets should be equal if the original subsets are equal
     partitions = StaticPartitionsDefinition([str(i) for i in range(1000)])
     subset = [str(i) for i in range(500)]
-    serialized1 = partitions.subset_with_partition_keys(subset).serialize()
-    serialized2 = partitions.subset_with_partition_keys(reversed(subset)).serialize()
-    assert serialized1 == serialized2
+
+    in_order_subset = partitions.subset_with_partition_keys(subset)
+    reverse_order_subset = partitions.subset_with_partition_keys(reversed(subset))
+
+    assert in_order_subset.serialize() == reverse_order_subset.serialize()
+    assert serialize_value(in_order_subset) == serialize_value(reverse_order_subset)
 
 
 def test_static_partitions_invalid_chars():