Skip to content

Commit

Permalink
remove executions resolver on GrapheneAssetCheck (#17651)
Browse files Browse the repository at this point in the history
Replaced by top level assetCheckExecutions resolver
  • Loading branch information
johannkm authored Nov 2, 2023
1 parent d7b069b commit 72642a8
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 29 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 0 additions & 7 deletions js_modules/dagster-ui/packages/ui-core/src/graphql/types.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from typing import TYPE_CHECKING, List, Optional, Union, cast
from typing import TYPE_CHECKING, Optional, Union, cast

import dagster._check as check
import graphene
Expand Down Expand Up @@ -132,12 +132,6 @@ class GrapheneAssetCheck(graphene.ObjectType):
name = graphene.NonNull(graphene.String)
assetKey = graphene.NonNull(GrapheneAssetKey)
description = graphene.String()
# deprecated. Use the top level assetCheckExecutions resolver instead
executions = graphene.Field(
non_null_list(GrapheneAssetCheckExecution),
limit=graphene.NonNull(graphene.Int),
cursor=graphene.String(),
)
executionForLatestMaterialization = graphene.Field(GrapheneAssetCheckExecution)
canExecuteIndividually = graphene.NonNull(GrapheneAssetCheckCanExecuteIndividually)

Expand All @@ -163,20 +157,6 @@ def resolve_name(self, _) -> str:
def resolve_description(self, _) -> Optional[str]:
return self._asset_check.description

def resolve_executions(
self, graphene_info: ResolveInfo, **kwargs
) -> List[GrapheneAssetCheckExecution]:
from dagster_graphql.implementation.fetch_asset_checks import (
fetch_asset_check_executions,
)

return fetch_asset_check_executions(
graphene_info.context.instance,
self._asset_check.key,
kwargs["limit"],
kwargs.get("cursor"),
)

def resolve_executionForLatestMaterialization(
self, _graphene_info: ResolveInfo
) -> Optional[GrapheneAssetCheckExecution]:
Expand Down

1 comment on commit 72642a8

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-68wzk3l8i-elementl.vercel.app

Built with commit 72642a8.
This pull request is being automatically deployed with vercel-action

Please sign in to comment.