Skip to content

Commit

Permalink
[ui] Hide “materialization planned” events from the log filter bar (#…
Browse files Browse the repository at this point in the history
…23437)

## Summary & Motivation

Related:
https://linear.app/dagster-labs/issue/FE-374/hide-planned-events-from-filter-typeahead-in-log-viewer

I verified that these logs are already filtered out of the log view
itself, but they were not filtered from the typeahead text input above
the log view. This list is mostly synthesized from the enum itself, so I
added a filter to remove them.


![image](https://github.com/user-attachments/assets/64584a61-3a8d-46a6-b5b2-530a241f7b14)

## How I Tested These Changes

Confirmed that they are no longer listed in the typeahead

Co-authored-by: bengotow <[email protected]>
  • Loading branch information
bengotow and bengotow authored Aug 6, 2024
1 parent f3ce9a8 commit 784e701
Showing 1 changed file with 11 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,17 @@ import uniq from 'lodash/uniq';
import {DagsterEventType} from '../graphql/types';

const typeValues = memoize(() =>
uniq(Object.values(DagsterEventType).map(eventTypeToDisplayType)).sort(),
uniq(
Object.values(DagsterEventType)
.filter(
(t) =>
![
DagsterEventType.ASSET_CHECK_EVALUATION_PLANNED,
DagsterEventType.ASSET_MATERIALIZATION_PLANNED,
].includes(t),
)
.map(eventTypeToDisplayType),
).sort(),
);

export const eventTypeToDisplayType = (eventType: string) => {
Expand Down

1 comment on commit 784e701

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-7b8t6g42b-elementl.vercel.app

Built with commit 784e701.
This pull request is being automatically deployed with vercel-action

Please sign in to comment.