Skip to content

Commit

Permalink
reverse gating
Browse files Browse the repository at this point in the history
  • Loading branch information
salazarm authored and OwenKephart committed Jan 17, 2024
1 parent 9cde05d commit 7cbae05
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 12 deletions.
2 changes: 1 addition & 1 deletion js_modules/dagster-ui/packages/ui-core/src/app/Flags.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export const FeatureFlag = {
flagDisableWebsockets: 'flagDisableWebsockets' as const,
flagSidebarResources: 'flagSidebarResources' as const,
flagDisableAutoLoadDefaults: 'flagDisableAutoLoadDefaults' as const,
flagUseOldAutomationPage: 'flagUseOldAutomationPage' as const,
flagUseNewAutomationPage: 'flagUseNewAutomationPage' as const,
};
export type FeatureFlagType = keyof typeof FeatureFlag;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export const getVisibleFeatureFlagRows = () => [
flagType: FeatureFlag.flagDebugConsoleLogging,
},
{
key: 'Use old asset auto-materialize history page',
flagType: FeatureFlag.flagUseOldAutomationPage,
key: 'Use new asset auto-materialize history page',
flagType: FeatureFlag.flagUseNewAutomationPage,
},
];
18 changes: 9 additions & 9 deletions js_modules/dagster-ui/packages/ui-core/src/assets/AssetView.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -184,21 +184,21 @@ export const AssetView = ({assetKey, trace}: Props) => {
);
};

const {flagUseOldAutomationPage} = useFeatureFlags();
const {flagUseNewAutomationPage} = useFeatureFlags();

const renderAutomaterializeHistoryTab = () => {
if (definitionQueryResult.loading && !definitionQueryResult.previousData) {
return <AssetLoadingDefinitionState />;
}
if (flagUseOldAutomationPage) {
return (
<AssetAutomaterializePolicyPageOld
assetKey={assetKey}
assetHasDefinedPartitions={!!definition?.partitionDefinition}
/>
);
if (flagUseNewAutomationPage) {
return <AssetAutomaterializePolicyPage assetKey={assetKey} definition={definition} />;
}
return <AssetAutomaterializePolicyPage assetKey={assetKey} definition={definition} />;
return (
<AssetAutomaterializePolicyPageOld
assetKey={assetKey}
assetHasDefinedPartitions={!!definition?.partitionDefinition}
/>
);
};

const renderChecksTab = () => {
Expand Down

0 comments on commit 7cbae05

Please sign in to comment.