Skip to content

Commit

Permalink
[external-assets] External asset renames
Browse files Browse the repository at this point in the history
  • Loading branch information
smackesey committed Mar 20, 2024
1 parent 05b414b commit 922d8ee
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
from dagster._core.errors import DagsterInvalidSubsetError
from dagster._core.selector.subset_selector import (
fetch_connected,
fetch_roots,
fetch_sinks,
fetch_sources,
parse_clause,
)
from dagster._core.storage.tags import TAG_NO_VALUE
Expand Down Expand Up @@ -748,7 +748,7 @@ def resolve_inner(
self, asset_graph: BaseAssetGraph, allow_missing: bool
) -> AbstractSet[AssetKey]:
selection = self.child.resolve_inner(asset_graph, allow_missing=allow_missing)
return fetch_sources(asset_graph.asset_dep_graph, selection)
return fetch_roots(asset_graph.asset_dep_graph, selection)

def to_serializable_asset_selection(self, asset_graph: BaseAssetGraph) -> "AssetSelection":
return self.replace(child=self.child.to_serializable_asset_selection(asset_graph))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -243,10 +243,10 @@ def fetch_sinks(
return sinks


def fetch_sources(
def fetch_roots(
graph: DependencyGraph[T_Hashable], within_selection: AbstractSet[T_Hashable]
) -> AbstractSet[T_Hashable]:
"""A source is a node that has no upstream dependencies within the provided selection.
"""A root is a node that has no upstream dependencies within the provided selection.
It can have other dependencies outside of the selection.
"""
dp: Dict[T_Hashable, bool] = {}
Expand Down

0 comments on commit 922d8ee

Please sign in to comment.