Skip to content

Commit

Permalink
Update eslint-config package version (#24013)
Browse files Browse the repository at this point in the history
## Summary & Motivation

Also add the one exception to the newly added rule

## How I Tested These Changes

## Changelog [New | Bug | Docs]

NOCHANGELOG
  • Loading branch information
salazarm authored Aug 28, 2024
1 parent c583313 commit 9809baa
Show file tree
Hide file tree
Showing 6 changed files with 37 additions and 5 deletions.
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import {gql, useMutation, useSuspenseQuery} from '@apollo/client';
import {
Body,
Box,
Expand All @@ -12,6 +11,7 @@ import {
Spinner,
TextInput,
} from '@dagster-io/ui-components';
import {gql, useMutation, useSuspenseQuery} from '@dagster-io/ui-core/apollo-client';
import {useStateWithStorage} from '@dagster-io/ui-core/hooks/useStateWithStorage';
import * as React from 'react';
import isEmail from 'validator/lib/isEmail';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import {ApolloLink} from '@apollo/client';
import {ApolloLink} from '@dagster-io/ui-core/apollo-client';
import {TelemetryAction, logTelemetry} from '@dagster-io/ui-core/app/Telemetry';

const TELEMETRY_WHITELIST = new Set([
Expand Down
4 changes: 4 additions & 0 deletions js_modules/dagster-ui/packages/eslint-config/CHANGES.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 1.0.16 (August 28, 2024)

- Added no-apollo-client rule.

## 1.0.15 (April 23, 2024)

- Dependency upgrades
Expand Down
2 changes: 1 addition & 1 deletion js_modules/dagster-ui/packages/eslint-config/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@dagster-io/eslint-config",
"version": "1.0.15",
"version": "1.0.16",
"description": "Shared eslint configuration for @dagster-io",
"license": "Apache-2.0",
"main": "index.js",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* eslint-disable no-restricted-imports */
/* eslint-disable no-restricted-imports, dagster-rules/no-apollo-client */
import {
LazyQueryHookOptions,
OperationVariables,
Expand Down
30 changes: 29 additions & 1 deletion js_modules/dagster-ui/yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -3596,7 +3596,29 @@ __metadata:
languageName: unknown
linkType: soft

"@dagster-io/eslint-config@npm:1.0.15, @dagster-io/eslint-config@workspace:*, @dagster-io/eslint-config@workspace:packages/eslint-config":
"@dagster-io/eslint-config@npm:1.0.15":
version: 1.0.15
resolution: "@dagster-io/eslint-config@npm:1.0.15"
dependencies:
"@typescript-eslint/eslint-plugin": "npm:^7.7.1"
"@typescript-eslint/parser": "npm:^7.7.1"
eslint-config-prettier: "npm:^9.1.0"
eslint-plugin-dagster-rules: "link:./rules"
eslint-plugin-import: "npm:^2.29.1"
eslint-plugin-jest: "npm:^27.9.0"
eslint-plugin-jsx-a11y: "npm:^6.8.0"
eslint-plugin-prettier: "npm:^5.1.3"
eslint-plugin-react: "npm:^7.34.1"
eslint-plugin-react-hooks: "npm:^4.6.0"
eslint-plugin-unused-imports: "npm:^3.1.0"
peerDependencies:
eslint: ^8.57.0
prettier: ^3.0.3
checksum: 10/ed220390ae550ddbabfa2fe3baaa1ed631b7c5c680eeb6dfd609e90ec1caa592c34f54ffa255aa888334ac03bb7f063fa38d8d27068bebcdc1c8d4c8a54472d3
languageName: node
linkType: hard

"@dagster-io/eslint-config@workspace:*, @dagster-io/eslint-config@workspace:packages/eslint-config":
version: 0.0.0-use.local
resolution: "@dagster-io/eslint-config@workspace:packages/eslint-config"
dependencies:
Expand Down Expand Up @@ -12517,6 +12539,12 @@ __metadata:
languageName: node
linkType: hard

"eslint-plugin-dagster-rules@link:./rules::locator=%40dagster-io%2Feslint-config%40npm%3A1.0.15":
version: 0.0.0-use.local
resolution: "eslint-plugin-dagster-rules@link:./rules::locator=%40dagster-io%2Feslint-config%40npm%3A1.0.15"
languageName: node
linkType: soft

"eslint-plugin-dagster-rules@link:./rules::locator=%40dagster-io%2Feslint-config%40workspace%3Apackages%2Feslint-config":
version: 0.0.0-use.local
resolution: "eslint-plugin-dagster-rules@link:./rules::locator=%40dagster-io%2Feslint-config%40workspace%3Apackages%2Feslint-config"
Expand Down

1 comment on commit 9809baa

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-mdvi0qexy-elementl.vercel.app

Built with commit 9809baa.
This pull request is being automatically deployed with vercel-action

Please sign in to comment.